这是indexloc提供的服务，不要输入任何密码
Skip to content

Migrate to GHC 8.10, upgrade dependencies. Closes #4517 #4518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2020
Merged

Migrate to GHC 8.10, upgrade dependencies. Closes #4517 #4518

merged 3 commits into from
May 14, 2020

Conversation

@jberryman
Copy link
Collaborator

@jberryman jberryman commented Apr 22, 2020

This also seems to squash a stubborn space leak we see with
subscriptions (linking to canonical #3388 for reference).

This may also fix some of the "Unexpected exception" websockets
exceptions we are now surfacing (see e.g. #4344)

Also: dev.sh: fix hpc reporting

Please install GHC 8.10 and give this a try and let me know if there are issues with your development setup that we can sort out.

You'll need cabal-install 3.2 (which you can upgrade with cabal; it will work with ghc 8.6.5 as well, but note the -new commands have now become default)

I install GHC from the bindists here:

https://www.haskell.org/ghc/download_ghc_8_10_1.html

It will clobber the symlinks from the last version you installed, but otherwise multiple ghc's play nice together (you can switch between them with the with-compiler config setting in a cabal.project or the -w flag to cabal).

@jberryman jberryman linked an issue Apr 23, 2020 that may be closed by this pull request
Migrate to GHC 8.10 #4517
Closed
4 tasks
@jberryman jberryman force-pushed the ghc-8.10-migration branch 2 times, most recently from 21616fa to c59edc9 Compare April 27, 2020 23:37
@netlify
Copy link

netlify bot commented Apr 27, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 19ffc3b

https://deploy-preview-4518--hasura-docs.netlify.app

@jberryman jberryman force-pushed the ghc-8.10-migration branch 3 times, most recently from 022c789 to c220dc4 Compare April 28, 2020 22:49
@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 29, 2020

Review app for commit de6c110 deployed to Heroku: https://hge-ci-pull-4518.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4518-de6c110a

@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 29, 2020

Review app for commit c03084e deployed to Heroku: https://hge-ci-pull-4518.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4518-c03084ef

@jberryman jberryman force-pushed the ghc-8.10-migration branch from c03084e to 03125cb Compare April 29, 2020 14:07
@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 29, 2020

Review app for commit 03125cb deployed to Heroku: https://hge-ci-pull-4518.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4518-03125cb0

@jberryman jberryman force-pushed the ghc-8.10-migration branch from 03125cb to e108619 Compare April 29, 2020 14:37
@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 29, 2020

Review app for commit e108619 deployed to Heroku: https://hge-ci-pull-4518.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4518-e1086196

@jberryman jberryman force-pushed the ghc-8.10-migration branch 3 times, most recently from 8e21e75 to 640bf7c Compare April 29, 2020 17:19
@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 29, 2020

Review app for commit 640bf7c deployed to Heroku: https://hge-ci-pull-4518.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4518-640bf7c4

@jberryman jberryman force-pushed the ghc-8.10-migration branch from 640bf7c to dd21ae6 Compare April 29, 2020 18:02
@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 29, 2020

Review app for commit dd21ae6 deployed to Heroku: https://hge-ci-pull-4518.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4518-dd21ae6f

@jberryman jberryman force-pushed the ghc-8.10-migration branch 2 times, most recently from 992e4a5 to 24a412e Compare April 29, 2020 19:03
@jberryman jberryman mentioned this pull request Apr 29, 2020
Merged
@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 29, 2020

Review app for commit 24a412e deployed to Heroku: https://hge-ci-pull-4518.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4518-24a412ec

@jberryman jberryman marked this pull request as ready for review May 7, 2020 14:39
@jberryman jberryman requested a review from a team as a code owner May 7, 2020 14:39
@hasura-bot
Copy link
Contributor

hasura-bot commented May 7, 2020

Review app for commit 09956e7 deployed to Heroku: https://hge-ci-pull-4518.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4518-09956e70

@jberryman jberryman requested review from 0x777 and abooij May 7, 2020 15:00
abooij
abooij suggested changes May 8, 2020
View reviewed changes
Copy link
Contributor

@abooij abooij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking forward to 8.10, so thanks for this.

@jberryman jberryman force-pushed the ghc-8.10-migration branch from 09956e7 to 8b4f14d Compare May 12, 2020 16:27
@jberryman jberryman requested a review from abooij May 12, 2020 16:28
@hasura-bot
Copy link
Contributor

hasura-bot commented May 12, 2020

Review app for commit 8b4f14d deployed to Heroku: https://hge-ci-pull-4518.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4518-8b4f14d0

abooij
abooij approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@abooij abooij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the source of the Docker image, which I think you're already working on. I am approving this PR now so that you can merge directly after resolving that.

@hasura-bot
Copy link
Contributor

hasura-bot commented May 13, 2020

Review app for commit 19ffc3b deployed to Heroku: https://hge-ci-pull-4518.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4518-19ffc3b1

@jberryman
Copy link
Collaborator Author

jberryman commented May 13, 2020

(@shahidhk thanks for doing the docker image!)

@hasura-bot
Copy link
Contributor

hasura-bot commented May 13, 2020

Review app for commit ab093d5 deployed to Heroku: https://hge-ci-pull-4518.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4518-ab093d5d

tirumaraiselvan
tirumaraiselvan approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog approved

@jberryman jberryman force-pushed the ghc-8.10-migration branch from ab093d5 to 6a3aaa0 Compare May 13, 2020 21:40
jberryman added 2 commits May 13, 2020 19:13
@jberryman
Migrate to GHC 8.10, upgrade dependencies. Closes hasura#4517
ff62d5e 
This also seems to squash a stubborn space leak we see with
subscriptions (linking to canonical hasura#3388 for reference).

This may also fix some of the "Unexpected exception" websockets
exceptions we are now surfacing (see e.g. hasura#4344)

Also: dev.sh: fix hpc reporting

Initial work on this done by Vamshi.
@jberryman
In websockets: rethrow resourceVanished as ConnectionClosed. Closes h…
a77bb05 
…asura#4344

...hopefully. At least I no longer can easily induce any unexpected
exceptions after this and the GHC 8.10 + libs upgrade commit.
@jberryman jberryman force-pushed the ghc-8.10-migration branch from 6a3aaa0 to a77bb05 Compare May 13, 2020 23:13
@hasura-bot
Copy link
Contributor

hasura-bot commented May 13, 2020

Review app for commit a77bb05 deployed to Heroku: https://hge-ci-pull-4518.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4518-a77bb057

@jberryman jberryman merged commit 9b247d4 into hasura:master May 14, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented May 14, 2020

Review app https://hge-ci-pull-4518.herokuapp.com is deleted

@jberryman jberryman deleted the ghc-8.10-migration branch May 14, 2020 00:34
@hgiasac hgiasac mentioned this pull request May 30, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk left review comments

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

@0x777 0x777 Awaiting requested review from 0x777

+1 more reviewer

@abooij abooij abooij approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate to GHC 8.10

5 participants

@jberryman @hasura-bot @abooij @shahidhk @tirumaraiselvan