这是indexloc提供的服务，不要输入任何密码
Skip to content

make the arguments field optional in ActionDefinition #4285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 4, 2020
Merged

make the arguments field optional in ActionDefinition #4285

merged 4 commits into from
Apr 4, 2020

Conversation

@codingkarthik
Copy link
Contributor

@codingkarthik codingkarthik commented Apr 3, 2020

Description

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code

    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields

    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

@codingkarthik codingkarthik requested a review from rakeshkky April 3, 2020 07:53
@codingkarthik codingkarthik requested a review from a team as a code owner April 3, 2020 07:53
@wawhal wawhal added this to the v1.2 milestone Apr 3, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 3, 2020

Review app for commit 49542e5 deployed to Heroku: https://hge-ci-pull-4285.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4285-49542e50

rakeshkky
rakeshkky approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@rakeshkky rakeshkky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 3, 2020

Review app for commit 2a36e29 deployed to Heroku: https://hge-ci-pull-4285.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4285-2a36e299

@codingkarthik codingkarthik requested a review from a team as a code owner April 3, 2020 12:11
@netlify
Copy link

netlify bot commented Apr 3, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 8794680

https://deploy-preview-4285--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 3, 2020

Review app for commit 7973867 deployed to Heroku: https://hge-ci-pull-4285.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4285-79738679

@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 3, 2020

Review app for commit 8794680 deployed to Heroku: https://hge-ci-pull-4285.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4285-8794680f

@lexi-lambda lexi-lambda merged commit a07a870 into hasura:master Apr 4, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 4, 2020

Review app https://hge-ci-pull-4285.herokuapp.com is deleted

@tirumaraiselvan tirumaraiselvan mentioned this pull request Apr 14, 2020
Closed
@codingkarthik codingkarthik mentioned this pull request Apr 23, 2020
Merged
32 tasks
rakeshkky pushed a commit to lexi-lambda/graphql-engine that referenced this pull request Jun 18, 2020
@codingkarthik @rakeshkky
make the arguments field optional in ActionDefinition (hasura#4285)
4e9e6a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rakeshkky rakeshkky rakeshkky approved these changes

+2 more reviewers

@lexi-lambda lexi-lambda lexi-lambda approved these changes

@marionschleifer marionschleifer marionschleifer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog-required

Projects

None yet

Milestone

v1.2

Development

Successfully merging this pull request may close these issues.

6 participants

@codingkarthik @hasura-bot @lexi-lambda @marionschleifer @rakeshkky @wawhal