这是indexloc提供的服务，不要输入任何密码
Skip to content

console: allow customising exposed column names of views (close #3689) #4255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 2, 2020
Merged

console: allow customising exposed column names of views (close #3689) #4255

merged 7 commits into from
Apr 2, 2020

Conversation

@wawhal
Copy link
Contributor

@wawhal wawhal commented Mar 31, 2020

Description

Currently, the UI does not allow customising the GraphQL field names for columns of views. This PR implements that.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

#3689

Steps to test and verify

Try editing the GraphQL field names of view columns.

@wawhal wawhal requested a review from a team as a code owner March 31, 2020 13:36
@wawhal wawhal changed the title allow customising exposed column names of views (close #3689) console: allow customising exposed column names of views (close #3689) Mar 31, 2020
@wawhal wawhal added c/console Related to console k/enhancement New feature or improve an existing feature labels Mar 31, 2020
@wawhal wawhal requested a review from a team as a code owner March 31, 2020 13:38
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 31, 2020

Review app for commit b1d3fa1 deployed to Heroku: https://hge-ci-pull-4255.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4255-b1d3fa13

marionschleifer
marionschleifer approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@marionschleifer marionschleifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog approved

rikinsk
rikinsk approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@rikinsk rikinsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX approved

@rikinsk rikinsk assigned beerose and unassigned rikinsk Apr 1, 2020
@rikinsk rikinsk requested a review from a team April 1, 2020 09:13
@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 1, 2020

Review app for commit 930d0f4 deployed to Heroku: https://hge-ci-pull-4255.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4255-930d0f40

beerose
beerose reviewed Apr 1, 2020
View reviewed changes
@netlify
Copy link

netlify bot commented Apr 1, 2020

Deploy preview for hasura-docs ready!

Built with commit 3f2e8a1

https://deploy-preview-4255--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 1, 2020

Review app for commit 3f2e8a1 deployed to Heroku: https://hge-ci-pull-4255.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4255-3f2e8a1b

@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 2, 2020

Review app for commit 4236ba5 deployed to Heroku: https://hge-ci-pull-4255.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4255-4236ba54

@rikinsk rikinsk merged commit 8bcff19 into hasura:master Apr 2, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 2, 2020

Review app https://hge-ci-pull-4255.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

+2 more reviewers

@marionschleifer marionschleifer marionschleifer approved these changes

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beerose beerose

Labels

c/console Related to console k/enhancement New feature or improve an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wawhal @hasura-bot @marionschleifer @beerose @rikinsk