console: allow customising root fields of single row mutations (close #4203) #4254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Review app for commit e89b1db deployed to Heroku: https://hge-ci-pull-4254.herokuapp.com |
beerose
approved these changes
Mar 31, 2020
| }} | ||
| deleteByPkOnChange={e => { | ||
| onChange('delete_by_pk', e.target.value); | ||
| }} |
Contributor
There was a problem hiding this comment.
It definitely looks like it needs some abstraction on onChange handlers 🙈
rikinsk
approved these changes
Mar 31, 2020
Member
|
Added changelog in #4253 |
Contributor
|
Review app for commit b674527 deployed to Heroku: https://hge-ci-pull-4254.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-4254.herokuapp.com is deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Single row mutations were introduced in
v1.2.0-beta.2. The UI however was not updated to allow customising root fields for these single row mutations. That's what this PR does.Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR.Affected components
Related Issues
#4203
Steps to test and verify
Try customising root fields for single row mutations