better handling for pgcrypto extension (fix #338) #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app available at: https://hge-ci-pull-423.herokuapp.com |
0x777
reviewed
Sep 12, 2018
server/src-exec/Ops.hs
Outdated
| if pgcryptoExtExists | ||
| -- only if we created the schema, create the extension | ||
| then when createSchema $ Q.unitQE needsPgCryptoExt "CREATE EXTENSION IF NOT EXISTS pgcrypto" () False | ||
| else liftIO $ putStrLn "FATAL: Could not find extension pgcrytpo. This extension is required." |
There was a problem hiding this comment.
shouldn't we be throwing an error here and exit?
0x777
approved these changes
Sep 14, 2018
|
Review app https://hge-ci-pull-423.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Mar 30, 2024
…ld name (#423) Fail schema generation if relationship name conflicts with object field name V3_GIT_ORIGIN_REV_ID: fcc979166bffe826c809e7992dd64afeff55c5f7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.