这是indexloc提供的服务，不要输入任何密码
Skip to content

console: fix handle long column names during update event trigger cre… #4210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2020
Merged

console: fix handle long column names during update event trigger cre… #4210

merged 2 commits into from
Mar 30, 2020

Conversation

@kawamataryo
Copy link
Contributor

@kawamataryo kawamataryo commented Mar 26, 2020 •
edited
Loading

Description

Fixed handle long column names during update event trigger creation. ( #4123 )

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

#4123

Solution and Design

Apply word break style.

スクリーンショット 2020-03-27 8 53 22

Steps to test and verify

Create a table with long column names and check event trigger creation

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code

    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields

    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

@kawamataryo kawamataryo requested a review from beerose as a code owner March 26, 2020 21:57
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 26, 2020

Beep boop! 🤖

Hey @kawamataryo, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Mar 26, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 13259b5

https://deploy-preview-4210--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 26, 2020

Review app for commit d5b1b57 deployed to Heroku: https://hge-ci-pull-4210.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4210-d5b1b573

@rikinsk
Copy link
Member

rikinsk commented Mar 27, 2020

@kawamataryo Thank you for raising this PR and contributing!

I would just like to request a couple of changes:

  • We currently seem to have multiple ways to display columns in a list. e.g.column permissions & update event trigger columns (the list in this PR).

    It would be great if we could maintain consistency of style with these lists. Could you please update your PR to use the columnListElement style class that is being used in the table column permissions section. The class might have to be moved to Common.scss from its current location.

  • the same change also has to be made to the event trigger modify page as shown here: https://hge-ci-pull-4210.herokuapp.com/console/events/manage/triggers/test_tr/modify

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 27, 2020

Review app for commit ae909a6 deployed to Heroku: https://hge-ci-pull-4210.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4210-ae909a6c

@kawamataryo kawamataryo force-pushed the fix-word-break-on-add-trigger branch from ae909a6 to 43e8df6 Compare March 27, 2020 21:21
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 27, 2020

Review app for commit 43e8df6 deployed to Heroku: https://hge-ci-pull-4210.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4210-43e8df62

@kawamataryo kawamataryo force-pushed the fix-word-break-on-add-trigger branch from 43e8df6 to 13259b5 Compare March 27, 2020 21:48
@kawamataryo
Copy link
Contributor Author

kawamataryo commented Mar 27, 2020

@rikinsk

Thanks for your review.
I fixed to use common columnStyleElements. And apply it to the event trigger change page.

@kawamataryo kawamataryo force-pushed the fix-word-break-on-add-trigger branch from 13259b5 to 146a9ff Compare March 28, 2020 00:58
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 28, 2020

Review app for commit 146a9ff deployed to Heroku: https://hge-ci-pull-4210.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4210-146a9ffa

@rikinsk rikinsk self-assigned this Mar 30, 2020
@rikinsk rikinsk added the c/console Related to console label Mar 30, 2020
@rikinsk rikinsk removed their assignment Mar 30, 2020
beerose
beerose approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

@kawamataryo kawamataryo force-pushed the fix-word-break-on-add-trigger branch from 146a9ff to 46e742a Compare March 30, 2020 11:13
@kawamataryo kawamataryo requested a review from a team as a code owner March 30, 2020 11:13
@beerose beerose assigned rikinsk and unassigned beerose Mar 30, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 30, 2020

Review app for commit 46e742a deployed to Heroku: https://hge-ci-pull-4210.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4210-46e742a4

@rikinsk rikinsk merged commit 7a443ce into hasura:master Mar 30, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 30, 2020

Beep boop! 🤖

GIF

Awesome work @kawamataryo! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 30, 2020

Review app https://hge-ci-pull-4210.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rikinsk rikinsk

Labels

c/console Related to console community-contrib 🙏🏽 no-changelog-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kawamataryo @hasura-bot @CLAassistant @rikinsk @beerose