这是indexloc提供的服务，不要输入任何密码
Skip to content

Add One-Click Render Deploy Doc (close #3683) #4209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 1, 2020
Merged

Add One-Click Render Deploy Doc (close #3683) #4209

merged 8 commits into from
Apr 1, 2020

Conversation

@anurag
Copy link
Contributor

@anurag anurag commented Mar 26, 2020 •
edited
Loading

Description

Add a single-click Deploy To Render guide for Hasura GraphQL Engine.

Close #3683.

This PR replaces #3684.

See https://github.com/render-examples/hasura-graphql for more.

Affected components

  • Docs

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 26, 2020

Beep boop! 🤖

Hey @anurag, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@netlify
Copy link

netlify bot commented Mar 26, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 27b0d4a

https://deploy-preview-4209--hasura-docs.netlify.com

@anurag anurag force-pushed the anurag/deploy-on-render branch from 0e5520d to 1c133dc Compare March 26, 2020 20:49
@anurag anurag force-pushed the anurag/deploy-on-render branch from 1c133dc to 4762e0e Compare March 26, 2020 20:50
@anurag anurag mentioned this pull request Mar 26, 2020
Closed
4 tasks
marionschleifer
marionschleifer suggested changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@marionschleifer marionschleifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anurag thank you for submitting this PR 🙂

I requested two small changes. Otherwise, this looks great. Also, it works like a charm, I tried it out 👍

@anurag anurag force-pushed the anurag/deploy-on-render branch from e500a87 to 6e0f8e6 Compare March 30, 2020 06:11
@anurag anurag requested a review from marionschleifer March 30, 2020 06:14
@marionschleifer
Copy link
Contributor

marionschleifer commented Mar 30, 2020

@anurag the order is still wrong in the navigation:

image

Here, in this index page, the render guide can come after Google cloud, and before the blog. Then we have the same order everywhere:

image

@anurag anurag requested review from a team as code owners March 30, 2020 15:38
@anurag
Copy link
Contributor Author

anurag commented Mar 30, 2020

@marionschleifer thanks. just fixed both the links.

@rikinsk rikinsk merged commit d7b94f4 into hasura:master Apr 1, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 1, 2020

Beep boop! 🤖

GIF

Awesome work @anurag! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 1, 2020

Review app https://hge-ci-pull-4209.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@marionschleifer marionschleifer marionschleifer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/docs Related to docs community-contrib 🙏🏽

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create a Deployment Guide for Render.com

4 participants

@anurag @hasura-bot @marionschleifer @rikinsk