-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix JSON(B) rendering in data browser (close #4201) #4221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Beep boop! 🤖 Hey @sobrinho, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. Stay awesome! 😎 |
|
Review app for commit 24c2f8b deployed to Heroku: https://hge-ci-pull-4221.herokuapp.com |
marionschleifer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog approved.
|
Review app for commit 25aa913 deployed to Heroku: https://hge-ci-pull-4221.herokuapp.com |
beerose
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @sobrinho!
Approving code changes.
|
/heroku deploy |
|
Review app for commit f7b149a deployed to Heroku: https://hge-ci-pull-4221.herokuapp.com |
|
Beep boop! 🤖 Awesome work @sobrinho! All of us at Hasura ❤️ what you did. Thanks again 🤗 |
|
Review app https://hge-ci-pull-4221.herokuapp.com is deleted |
Description
Hasura was rendering strings and objects as the same in browse rows, we couldn't differentiate one from another.
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR.Affected components
Related Issues
#4201
Solution and Design
Checking if the column is a JSON or JSONB type instead of only if the value is an object fix the issue.
Before (You couldn't tell that one of the rows is a string by mistake):
After (You can see the difference clearly):
Steps to test and verify
Create one json and one jsonb columns, create two rows, one with both values as
{"object":true}and another one with both values as"{\"string\": \"true\"}".You can't tell the difference in
Browse Rowsbefore and you should after this fix.Limitations, known bugs & workarounds
None.
Server checklist
None.
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
run_sqlauto manages the new metadata through schema diffing?run_sqlauto manages the definitions of metadata on renaming?export_metadata/replace_metadatasupports the new metadata added?GraphQL
Breaking changes
No Breaking changes
There are breaking changes:
Metadata API
Existing
querytypes:argspayload which is not backward compatibleJSONschemaGraphQL API
Schema Generation:
NamedTypeSchema Resolve:-
nullvalue for any input fieldsLogging
JSONschema has changedtypenames have changed