这是indexloc提供的服务，不要输入任何密码
Skip to content

cli: allow customization of server api paths (close #4016) #4174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 8, 2020
Merged

cli: allow customization of server api paths (close #4016) #4174

merged 9 commits into from
Apr 8, 2020

Conversation

@arvi3411301
Copy link
Member

@arvi3411301 arvi3411301 commented Mar 24, 2020 •
edited
Loading

Description

This PR adds support for the customization of server API paths in CLI.

endpoint: http://localhost:8080
api_paths:
  query: stable/query
  graphql: stable/graphql
  version: stable/version
  pg_dump: stable/pg_dump
  config: stable/config

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

#4016

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@arvi3411301 arvi3411301 added the c/cli Related to CLI label Mar 24, 2020
@arvi3411301 arvi3411301 requested a review from shahidhk March 24, 2020 09:45
@arvi3411301 arvi3411301 added this to the v1.2 milestone Mar 24, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 24, 2020

Review app for commit 57d6d68 deployed to Heroku: https://hge-ci-pull-4174.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4174-57d6d685

@arvi3411301 arvi3411301 added the s/do-not-merge Do not merge this pull request to master label Mar 25, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 26, 2020

Review app for commit 2406938 deployed to Heroku: https://hge-ci-pull-4174.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4174-24069382

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 26, 2020

Review app for commit 801d7df deployed to Heroku: https://hge-ci-pull-4174.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4174-801d7dfe

@arvi3411301 arvi3411301 assigned karthikvt26 and unassigned shahidhk Mar 31, 2020
@arvi3411301 arvi3411301 requested a review from a team as a code owner March 31, 2020 09:01
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 31, 2020

Review app for commit fbf40b7 deployed to Heroku: https://hge-ci-pull-4174.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4174-fbf40b71

@arvi3411301 arvi3411301 removed the s/do-not-merge Do not merge this pull request to master label Apr 7, 2020
@shahidhk shahidhk changed the title cli: allow customization of server api paths cli: allow customization of server api paths (close #4016) Apr 8, 2020
@shahidhk shahidhk requested a review from a team as a code owner April 8, 2020 05:27
marionschleifer
marionschleifer approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@marionschleifer marionschleifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog approved.

@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 8, 2020

Review app for commit 0e67a3e deployed to Heroku: https://hge-ci-pull-4174.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4174-0e67a3ed

@shahidhk shahidhk merged commit 21b61af into hasura:master Apr 8, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 8, 2020

Review app https://hge-ci-pull-4174.herokuapp.com is deleted

@shahidhk shahidhk deleted the issue-4016 branch April 8, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk approved these changes

+2 more reviewers

@marionschleifer marionschleifer marionschleifer approved these changes

@scriptonist scriptonist scriptonist approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/cli Related to CLI

Projects

None yet

Milestone

v1.2

Development

Successfully merging this pull request may close these issues.

6 participants

@arvi3411301 @hasura-bot @shahidhk @marionschleifer @scriptonist @karthikvt26