这是indexloc提供的服务，不要输入任何密码
Skip to content

cli: add support for multiple versions of plugin (close #4105) #4135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 7, 2020
Merged

cli: add support for multiple versions of plugin (close #4105) #4135

merged 9 commits into from
Apr 7, 2020

Conversation

@arvi3411301
Copy link
Member

@arvi3411301 arvi3411301 commented Mar 17, 2020 •
edited
Loading

Description

This PR adds support for handling multiple versions of a plugin.

Commands changed:

  1. hasura plugins install now takes version flag.
  2. hasura plugins upgrade now takes version flag.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Solution and Design

Instead of handling a single version of a plugin, plugins will store the list of versions in an index and respective manifest in a map. On every append to the index and map, the versions will be sorted.

By doing this, we can retrieve the latest version from the last item in the index. Also, we can retrieve a particular version from the index.

Plugins Repo can handle both file or folder-based structure.

Steps to test and verify

Limitations, known bugs & workarounds

@arvi3411301 arvi3411301 added the c/cli Related to CLI label Mar 17, 2020
@arvi3411301 arvi3411301 requested a review from shahidhk March 17, 2020 22:59
@arvi3411301 arvi3411301 added this to the v1.2 milestone Mar 17, 2020
@netlify
Copy link

netlify bot commented Mar 17, 2020

Deploy preview for hasura-docs ready!

Built with commit 33d41ee

https://deploy-preview-4135--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 17, 2020

Review app for commit 52ed819 deployed to Heroku: https://hge-ci-pull-4135.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4135-52ed819f

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 25, 2020

Review app for commit 65c227b deployed to Heroku: https://hge-ci-pull-4135.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4135-65c227bc

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 25, 2020

Review app for commit 815ca43 deployed to Heroku: https://hge-ci-pull-4135.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4135-815ca433

@shahidhk shahidhk changed the title cli: add support for multiple versions of plugin cli: add support for multiple versions of plugin (close #4105) Mar 25, 2020
@arvi3411301 arvi3411301 requested review from a team as code owners April 2, 2020 09:39
@arvi3411301 arvi3411301 added the s/do-not-merge Do not merge this pull request to master label Apr 2, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 2, 2020

Review app for commit 0052ce6 deployed to Heroku: https://hge-ci-pull-4135.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4135-0052ce69

@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 2, 2020

Review app for commit fcb4379 deployed to Heroku: https://hge-ci-pull-4135.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4135-fcb4379b

@arvi3411301 arvi3411301 removed the s/do-not-merge Do not merge this pull request to master label Apr 3, 2020
@shahidhk shahidhk merged commit d5e6171 into hasura:master Apr 7, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 7, 2020

Review app https://hge-ci-pull-4135.herokuapp.com is deleted

@shahidhk shahidhk deleted the issue-4105 branch April 7, 2020 14:12
@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 7, 2020

Review app for commit cc4463b deployed to Heroku: https://hge-ci-pull-4135.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4135-cc4463b0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk approved these changes

@marionschleifer marionschleifer Awaiting requested review from marionschleifer

Assignees

@shahidhk shahidhk

Labels

c/cli Related to CLI

Projects

None yet

Milestone

v1.2

Development

Successfully merging this pull request may close these issues.

3 participants

@arvi3411301 @hasura-bot @shahidhk