console shared modules: fix parsing of wrapped types in SDL #4167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Review app for commit f47c1fc deployed to Heroku: https://hge-ci-pull-4167.herokuapp.com |
marionschleifer
approved these changes
Mar 23, 2020
Contributor
marionschleifer
left a comment
There was a problem hiding this comment.
Changelog approved.
beerose
approved these changes
Mar 24, 2020
Contributor
|
Review app for commit 581303b deployed to Heroku: https://hge-ci-pull-4167.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-4167.herokuapp.com is deleted |
anurag
pushed a commit
to anurag/graphql-engine
that referenced
this pull request
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the the type is wrapped with a combination of arrays and non-nullables in SDL (ex:
[String!]!), console reverses the order currently.This PR fixes it.
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR.Affected components
Related Issues
#4099
Steps to test and verify
Try writing arbitrary types in SDL format in actions. Ex:
[[Int]!]!. Hit save, the order must be maintained.