这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@0x777
Copy link
Member

@0x777 0x777 commented Mar 13, 2020

@netlify
Copy link

netlify bot commented Mar 13, 2020

Deploy preview for hasura-docs ready!

Built with commit 233ab64

https://deploy-preview-4110--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

Review app for commit 233ab64 deployed to Heroku: https://hge-ci-pull-4110.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4110-233ab645

@aleksandersumowski
Copy link

Thanks for the RFCs! I've read through them and the features proposed seem to go a long way to meet our needs.

As I understand it, we'll be able to disable subscriptions altogether, enable querying for some of the entities just via relations and enable/disable the use of certain fields in filter conditions. Thats great!

One scenario that seems to be not covered is multi-field filtering - you need to enable filtering on all the fields from the condition and that means users can filter only on the second or further column in the index. Eg to use index on order_items_extended_attributes with columns (tenant, order_item_id, name) we would have to enable column name. And in that case someone could make a query filtering just by name which wouldn't use the index.

@tirumaraiselvan tirumaraiselvan modified the milestones: v1.3, v1.4 Apr 9, 2020
@marbemac
Copy link

This would also make our permissioning setup so much cleaner (and likely more performant). As of now for our more nested data models, e.g. organization -> project -> things in project, we need to basically repeat all of the org and project permission checks on the tables for things inside of the project. This will be a fantastic change 👍. Any idea on rough timeline post RFC acceptance? Months, quarters?

@tirumaraiselvan tirumaraiselvan linked an issue Apr 11, 2020 that may be closed by this pull request
@jlowin
Copy link

jlowin commented May 23, 2020

We currently resort to schema stitching to achieve this; would love to see this feature

@franciscolourenco
Copy link

Really need this. Any prospects on the implementation of this feature? Thanks!

@francois-pasquier
Copy link

francois-pasquier commented Sep 9, 2020

Could the rfc add the possibility to disable the where argument #5751

Is anyone looking into the implementation?

@mathieutu
Copy link

Hi, this would be a killer feature for us.

However why limit that to query and subscriptions ? I would add the ability to manage the same permissions for mutations too.

@tirumaraiselvan tirumaraiselvan modified the milestones: v1.4, vNext Oct 20, 2020
@switz
Copy link

switz commented Jan 23, 2021

Any plans to implement blocking root level queries? This would be a huge permissioning win.

@jberryman
Copy link
Collaborator

This sounds good, but may be a fragile or dangerous way to create permissions. For a complex DB schema it may be difficult to see where some data might leak. It should be possible to compute the implicit permissions to show the admin, or even ensure that those don't change if the schema changes.

Just some thoughts

@marbemac
Copy link

marbemac commented Apr 15, 2021

Any plans to implement blocking root level queries? This would be a huge permissioning win.

👌 this pretty much sums it up - a "simple" (obv I don't really know if it is, but I like to imagine it is :)) option to track a table so that it can be exposed over relations, etc, but not expose it at the root level, would dramatically simplify so much of the permissions we have to maintain today - like 10x improvement, we'd be able to drop most of them completely <3.

@Ambro17
Copy link

Ambro17 commented May 28, 2021

Is this RFC accepted? Is it on roadmap? I'm trying hasura and really liked it so far, but without this i will be forced to drop it

@VNadygin
Copy link

Any news on it?

@PhillipHoffmann
Copy link

This is very much needed.

@marbemac
Copy link

From how it reads, it seems like release 2.8 might solve this (I have not tried the functionality yet, we're still on 2.1) - specifically #696. @tirumaraiselvan is that correct?

@tirumaraiselvan
Copy link
Contributor

Yes, 2.8 solves this. We will merge this PR soon.

@tirumaraiselvan
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

k/rfc RFC for a new feature / process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow access to a relationship separately from the full table