这是indexloc提供的服务，不要输入任何密码
Skip to content

few actions' fixes and improvements (fix #3977, #4061 & close #4021) #4109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 20, 2020
Merged

few actions' fixes and improvements (fix #3977, #4061 & close #4021) #4109

merged 10 commits into from
Mar 20, 2020

Conversation

@rakeshkky
Copy link
Member

@rakeshkky rakeshkky commented Mar 13, 2020 •
edited
Loading

Description

#3977 - Validate the JSON response from the webhook handler whether it conforms to the output type of the action
#4021 - Pass down the response headers (Set-Cookie) from the webhook handler to the client. Applies only for sync actions.
#4061 - The default GraphQL scalar ID isn't included in custom types.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Fix #3977 & #4061, Close #4021

Solution and Design

#3977 - The response of webhook should contain all fields in output whose type is non-nullable and the values shouldn't be null. See the function validateResponseObject in Hasura.GraphQL.Resolve.Action module.
#4021 - Webhook response Set-Cookie headers are sent to client.
#4061 - Include ID in defaultScalars in Hasura.RQL.DDL.CustomTypes module.

Steps to test and verify

Follow the reproduction guides in respective issues.

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes

Breaking changes

  • No Breaking changes
  • There are breaking changes

@rakeshkky rakeshkky added c/server Related to server c/actions Related to actions labels Mar 13, 2020
@rakeshkky rakeshkky self-assigned this Mar 13, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 13, 2020

Review app for commit 01c06bb deployed to Heroku: https://hge-ci-pull-4109.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4109-01c06bb9

@netlify
Copy link

netlify bot commented Mar 13, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 6e43c59

https://deploy-preview-4109--hasura-docs.netlify.com

@rakeshkky rakeshkky force-pushed the issue-3977-4021-4061 branch from 01c06bb to 6e43c59 Compare March 13, 2020 18:09
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 13, 2020

Review app for commit 6e43c59 deployed to Heroku: https://hge-ci-pull-4109.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4109-6e43c591

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 16, 2020

Review app for commit bd28482 deployed to Heroku: https://hge-ci-pull-4109.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4109-bd28482c

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 16, 2020

Review app for commit 6394474 deployed to Heroku: https://hge-ci-pull-4109.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4109-63944746

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 16, 2020

Review app for commit 4384439 deployed to Heroku: https://hge-ci-pull-4109.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4109-4384439f

@rakeshkky rakeshkky marked this pull request as ready for review March 17, 2020 09:23
@rakeshkky rakeshkky requested a review from 0x777 March 17, 2020 09:23
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 17, 2020

Review app for commit 3671037 deployed to Heroku: https://hge-ci-pull-4109.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4109-3671037e

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 18, 2020

Review app for commit 4118c68 deployed to Heroku: https://hge-ci-pull-4109.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4109-4118c681

marionschleifer
marionschleifer approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@marionschleifer marionschleifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog approved.

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 19, 2020

Review app for commit 3d4c889 deployed to Heroku: https://hge-ci-pull-4109.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4109-3d4c889b

@0x777 0x777 merged commit f80b69e into hasura:master Mar 20, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 20, 2020

Review app https://hge-ci-pull-4109.herokuapp.com is deleted

rakeshkky added a commit to lexi-lambda/graphql-engine that referenced this pull request Jun 17, 2020
@rakeshkky @0x777
[skip ci] few actions' fixes and improvements (fix hasura#3977, hasur…
28ad5ea 
…a#4061 & close hasura#4021) (hasura#4109)

* add 'ID' to default scalars for custom types, fix hasura#4061

* preserve cookie headers from sync action webhook, close hasura#4021

* validate action webhook response to conform to output type, fix hasura#3977

* fix tests, don't run actions' tests on PG version < 10

* update CHANGELOG.md

* no-op refactor, use types from http-network more

Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
@Allymahmoud Allymahmoud mentioned this pull request Dec 6, 2023
Open
@ptakpatryk ptakpatryk mentioned this pull request Dec 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 approved these changes

@lexi-lambda lexi-lambda Awaiting requested review from lexi-lambda

@shahidhk shahidhk Awaiting requested review from shahidhk

+1 more reviewer

@marionschleifer marionschleifer marionschleifer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rakeshkky rakeshkky

Labels

c/actions Related to actions c/server Related to server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

actions: preserve response headers from webhook Hasura Actions: non-nullable fields can return null

4 participants

@rakeshkky @hasura-bot @marionschleifer @0x777