console: unique filenames for exported metadata (close #1772) #4106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit 6ca9fae |
Contributor
|
Review app for commit 130478f deployed to Heroku: https://hge-ci-pull-4106.herokuapp.com |
beerose
reviewed
Mar 16, 2020
|
|
||
| const month = (currTime.getMonth() + 1).toString().padStart(2, '0'); | ||
|
|
||
| const date = currTime |
…l-engine into console-metadata-filename
Contributor
|
Review app for commit 0d5ca72 deployed to Heroku: https://hge-ci-pull-4106.herokuapp.com |
beerose
approved these changes
Mar 18, 2020
Contributor
|
Review app for commit 6ca9fae deployed to Heroku: https://hge-ci-pull-4106.herokuapp.com |
marionschleifer
approved these changes
Mar 18, 2020
Contributor
marionschleifer
left a comment
There was a problem hiding this comment.
Changelog approved 🙏
Contributor
|
Review app https://hge-ci-pull-4106.herokuapp.com is deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generate metadata filenames such as:
hasura_metadata_2020_03_13_18_10_31_711.jsonChangelog
CHANGELOG.mdis updated with user-facing content relevant to this PR.Affected components
Related Issues
#1772
Solution and Design
Steps to test and verify
Head to
/settings/metadata-actionspage and hitExport Metadata. Observe downloaded file filenameLimitations, known bugs & workarounds