cli: send command path in telemetry data #4095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Review app for commit daa584f deployed to Heroku: https://hge-ci-pull-4095.herokuapp.com |
Contributor
|
Review app for commit 1e59f87 deployed to Heroku: https://hge-ci-pull-4095.herokuapp.com |
shahidhk
approved these changes
Mar 26, 2020
Contributor
|
Review app https://hge-ci-pull-4095.herokuapp.com is deleted |
Contributor
|
Review app for commit 4378df8 deployed to Heroku: https://hge-ci-pull-4095.herokuapp.com |
anurag
pushed a commit
to anurag/graphql-engine
that referenced
this pull request
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two issues with CLI
commandfield is not being set in telemetry data and auto update check doesn't work if there is aPersistentPreRunEon a subcommand.commandfield is not being set in telemetry data if user runshasura migrateor any other command which is not runnable.Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR.Affected components
Related Issues
#4127
Solution and Design
commandfield in telemetry data, useExecuteCto get the command which is executed and use the command path.PersistentPreRunE, callcmd.Root().PersistentPreRun(cmd, args)Steps to test and verify
Limitations, known bugs & workarounds
Auto update check doesn't work if a command is not runnable