hasura · rikinsk · Mar 13, 2020 · Feb 27, 2020 · Mar 11, 2020 · Mar 11, 2020
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -81,4 +81,5 @@
 - add meta descriptions to actions docs (#4082)
 - `HASURA_GRAPHQL_EVENTS_FETCH_INTERVAL` changes semantics slightly: we only sleep for the interval
   when there were previously no events to process. Potential space leak fixed. (#3839)
+- console: track runtime errors (#4083)
 - auto-include `__typename` field in custom types' objects (fix #4063)
@@ -19,7 +19,9 @@ import getRoutes from './routes';
 import reducer from './reducer';
 import globals from './Globals';
 import Endpoints from './Endpoints';
+
 import { filterEventsBlockList, sanitiseUrl } from './telemetryFilter';
+import { RUN_TIME_ERROR } from './components/Main/Actions';
 
 /** telemetry **/
 let analyticsConnection;
@@ -57,46 +59,55 @@ function analyticsLogger({ getState }) {
   return next => action => {
     // Call the next dispatch method in the middleware chain.
     const returnValue = next(action);
+
     // check if analytics tracking is enabled
     if (telemetryEnabled) {
-      const serverVersion = getState().main.serverVersion;
       const actionType = action.type;
-      const url = sanitiseUrl(window.location.pathname);
-      const reqBody = {
-        server_version: serverVersion,
-        event_type: actionType,
-        url,
-        console_mode: consoleMode,
-        cli_uuid: cliUUID,
-        server_uuid: getState().telemetry.hasura_uuid,
-      };
-
-      let isLocationType = false;
-      if (actionType === '@@router/LOCATION_CHANGE') {
-        isLocationType = true;
-      }
+
       // filter events
       if (!filterEventsBlockList.includes(actionType)) {
+        // When the connection is open, send data to the server
         if (
           analyticsConnection &&
           analyticsConnection.readyState === analyticsConnection.OPEN
         ) {
-          // When the connection is open, send data to the server
+          const serverVersion = getState().main.serverVersion;
+          const url = sanitiseUrl(window.location.pathname);
+
+          const reqBody = {
+            server_version: serverVersion,
+            event_type: actionType,
+            url,
+            console_mode: consoleMode,
+            cli_uuid: cliUUID,
+            server_uuid: getState().telemetry.hasura_uuid,
+          };
+
+          const isLocationType = actionType === '@@router/LOCATION_CHANGE';
           if (isLocationType) {
             // capture page views
             const payload = action.payload;
             reqBody.url = sanitiseUrl(payload.pathname);
           }
+
+          const isErrorType = actionType === RUN_TIME_ERROR;
+          if (isErrorType) {
+            reqBody.data = action.data;
+          }
+
+          // Send the data
           analyticsConnection.send(
             JSON.stringify({ data: reqBody, topic: globals.telemetryTopic })
-          ); // Send the data
+          );
+
           // check for possible error events and store more data?
         } else {
           // retry websocket connection
           // analyticsConnection = new WebSocket(analyticsUrl);
         }
       }
     }
+
     // This will likely be the action itself, unless
     // a middleware further in chain changed it.
     return returnValue;

@@ -9,6 +9,7 @@ import Spinner from '../Common/Spinner/Spinner';
 
 import PageNotFound, { NotFoundError } from './PageNotFound';
 import RuntimeError from './RuntimeError';
+import { registerRunTimeError } from '../Main/Actions';
 
 class ErrorBoundary extends React.Component {
   initialState = {
@@ -40,6 +41,11 @@ class ErrorBoundary extends React.Component {
 
     this.setState({ hasError: true, info: info, error: error });
 
+    // trigger telemetry
+    dispatch(
+      registerRunTimeError({ message: error.message, stack: error.stack })
+    );
+
     dispatch(loadInconsistentObjects(true)).then(() => {
       if (this.props.metadata.inconsistentObjects.length > 0) {
         if (!isMetadataStatusPage()) {

@@ -22,6 +22,12 @@ const UPDATE_ADMIN_SECRET_INPUT = 'Main/UPDATE_ADMIN_SECRET_INPUT';
 const LOGIN_IN_PROGRESS = 'Main/LOGIN_IN_PROGRESS';
 const LOGIN_ERROR = 'Main/LOGIN_ERROR';
 
+const RUN_TIME_ERROR = 'Main/RUN_TIME_ERROR';
+const registerRunTimeError = data => ({
+  type: RUN_TIME_ERROR,
+  data,
+});
+
 /* Server config constants*/
 const FETCHING_SERVER_CONFIG = 'Main/FETCHING_SERVER_CONFIG';
 const SERVER_CONFIG_FETCH_SUCCESS = 'Main/SERVER_CONFIG_FETCH_SUCCESS';
@@ -273,6 +279,8 @@ const mainReducer = (state = defaultState, action) => {
       return { ...state, loginInProgress: action.data };
     case LOGIN_ERROR:
       return { ...state, loginError: action.data };
+    case RUN_TIME_ERROR: // To trigger telemetry event
+      return state;
     case FETCHING_SERVER_CONFIG:
       return {
         ...state,
@@ -327,4 +335,6 @@ export {
   fetchServerConfig,
   loadLatestServerVersion,
   featureCompatibilityInit,
+  RUN_TIME_ERROR,
+  registerRunTimeError,
 };