这是indexloc提供的服务，不要输入任何密码
Skip to content

disable renaming action relationships on console #4072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 11, 2020
Merged

disable renaming action relationships on console #4072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1b546b6
disable renaming action relationships
Mar 10, 2020
c194de9
update changelog
Mar 10, 2020
6126cc9
Merge branch 'master' into disbale-renaming-action-rel
rikinsk Mar 11, 2020
427614a
Merge branch 'master' into disbale-renaming-action-rel
rikinsk Mar 11, 2020
67e4907
Merge branch 'master' into disbale-renaming-action-rel
rikinsk Mar 11, 2020
b335399
Merge branch 'master' into disbale-renaming-action-rel
rikinsk Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

### Other changes

- console: disable editing action relationships
- cli: fix typo in cli example for squash (fix #4047) (#4049)
- console: fix run_sql migration modal messaging (close #4020) (#4060)
- docs: add note on pg versions for actions (#4034)
Expand Down
31 changes: 21 additions & 10 deletions console/src/components/Services/Actions/Relationships/Components/TypeRelationship.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,15 @@ const RelationshipEditor = ({

// rel name input
const getRelNameInput = () => {
/*
There is no neat solution to renaming a relationship.
This is because name is the only unique identifier of a relationship.
TODO FIXME
*/
const isDisabled = !!existingRelConfig;
Copy link
Contributor

@beerose beerose Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving anyway, but is new variable really needed?

const relNameInputTitle = isDisabled
? 'A relationship cannot be renamed. Please drop and re-create if you really must.'
: undefined;
return (
<div className={`${styles.add_mar_bottom}`}>
<div className={`${styles.add_mar_bottom_mid}`}>
Expand All @@ -129,6 +138,8 @@ const RelationshipEditor = ({
className={`${styles.select} form-control ${styles.add_pad_left}`}
placeholder="Enter relationship name"
data-test="rel-name"
disabled={isDisabled}
title={relNameInputTitle}
value={name}
/>
</div>
Expand Down Expand Up @@ -180,17 +191,17 @@ const RelationshipEditor = ({
disabled={!name}
>
{// default unselected option
refSchema === '' && (
<option value={''} disabled>
{'-- reference schema --'}
</option>
)}
refSchema === '' && (
<option value={''} disabled>
{'-- reference schema --'}
</option>
)}
{// all reference schema options
orderedSchemaList.map((rs, j) => (
<option key={j} value={rs}>
{rs}
</option>
))}
orderedSchemaList.map((rs, j) => (
<option key={j} value={rs}>
{rs}
</option>
))}
</select>
</div>
);
Expand Down