这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@wawhal
Copy link
Contributor

@wawhal wawhal commented Mar 8, 2020

Description

  • Move setting process.hrtime to webpack so that codegen is usable in
    pro
  • Fix warnings and unnecessary console errors
  • Disable snippets for aceeditor

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Steps to test and verify

Create an action and go to its codegen tab. Should work without any errors in dev console.

- Move setting process.hrtime to webpack so that codegen is usable in
pro
- Fix warnings and unnecessary console errors
- Disable snippets for aceeditor
@wawhal wawhal requested a review from karthikvt26 March 8, 2020 10:41
@wawhal wawhal requested a review from beerose as a code owner March 8, 2020 10:41
@hasura-bot
Copy link
Contributor

Review app for commit 0b05b81 deployed to Heroku: https://hge-ci-pull-4059.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4059-0b05b81d

@tirumaraiselvan tirumaraiselvan added this to the v1.2.0 milestone Mar 13, 2020
@tirumaraiselvan tirumaraiselvan added the c/actions Related to actions label Mar 17, 2020
@wawhal wawhal requested a review from rikinsk March 18, 2020 13:43
@hasura-bot
Copy link
Contributor

Review app for commit 033279c deployed to Heroku: https://hge-ci-pull-4059.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4059-033279c6

Copy link
Contributor

@karthikvt26 karthikvt26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rikinsk rikinsk merged commit 2a24b66 into hasura:master Mar 19, 2020
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-4059.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/actions Related to actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants