这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@arvi3411301
Copy link
Member

@arvi3411301 arvi3411301 commented Mar 2, 2020

Description

This PR fixes a bug which does not preserve action definition during metadata apply

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

#3988

Solution and Design

During metadata apply, preserve the action definition fields in the build method.

Steps to test and verify

Limitations, known bugs & workarounds

@arvi3411301 arvi3411301 added the c/cli Related to CLI label Mar 2, 2020
@arvi3411301 arvi3411301 requested a review from shahidhk March 2, 2020 10:31
@arvi3411301 arvi3411301 changed the title cli: preserve action definition in metadata apply cli: preserve action definition in metadata apply (close #3988) Mar 2, 2020
@hasura-bot
Copy link
Contributor

Review app for commit 30637eb deployed to Heroku: https://hge-ci-pull-3993.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3993-30637eb1

@hasura-bot
Copy link
Contributor

Review app for commit a16c834 deployed to Heroku: https://hge-ci-pull-3993.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3993-a16c834e

@shahidhk shahidhk changed the title cli: preserve action definition in metadata apply (close #3988) cli(actions): preserve action definition in metadata apply (close #3988) Mar 3, 2020
@netlify
Copy link

netlify bot commented Mar 3, 2020

Deploy preview for hasura-docs ready!

Built with commit 9b19fed

https://deploy-preview-3993--hasura-docs.netlify.com

@shahidhk shahidhk changed the title cli(actions): preserve action definition in metadata apply (close #3988) cli(actions): preserve action definition in metadata apply (fix #3988) Mar 3, 2020
@shahidhk shahidhk merged commit 28941b4 into hasura:master Mar 3, 2020
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-3993.herokuapp.com is deleted

@shahidhk shahidhk deleted the issue-3988 branch March 3, 2020 07:06
@hasura-bot
Copy link
Contributor

Review app for commit 186997f deployed to Heroku: https://hge-ci-pull-3993.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3993-186997fd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/cli Related to CLI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants