这是indexloc提供的服务，不要输入任何密码
Skip to content

cli: bug fixes related to actions #3951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 25, 2020
Merged

cli: bug fixes related to actions #3951

merged 6 commits into from
Feb 25, 2020

Conversation

@arvi3411301
Copy link
Member

@arvi3411301 arvi3411301 commented Feb 25, 2020 •
edited
Loading

Description

This PR fixes issue with metadata apply unable to unmarshal functions,query_collections in metadata.

Other Fixes:

  • Change cli-ext binary name
  • Add upx in cli-ext docker image. (But upx is not yet support with pkg )

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

@arvi3411301 arvi3411301 added c/cli Related to CLI s/do-not-merge Do not merge this pull request to master labels Feb 25, 2020
@netlify
Copy link

netlify bot commented Feb 25, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 8430bc2

https://deploy-preview-3951--hasura-docs.netlify.com

@arvi3411301 arvi3411301 marked this pull request as ready for review February 25, 2020 14:16
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 25, 2020

Review app for commit 8430bc2 deployed to Heroku: https://hge-ci-pull-3951.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3951-8430bc2f

rikinsk
rikinsk approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@rikinsk rikinsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality checked

@arvi3411301 arvi3411301 removed the s/do-not-merge Do not merge this pull request to master label Feb 25, 2020
@shahidhk shahidhk merged commit 21e6dd7 into hasura:master Feb 25, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 25, 2020

Review app https://hge-ci-pull-3951.herokuapp.com is deleted

@shahidhk shahidhk deleted the cli-actions-fix branch February 25, 2020 14:58
shahidhk pushed a commit that referenced this pull request Feb 26, 2020
@arvi3411301 @shahidhk
cli: bug fixes related to actions (#3951)
0101f28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk approved these changes

@rikinsk rikinsk rikinsk approved these changes

Assignees

No one assigned

Labels

c/cli Related to CLI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arvi3411301 @hasura-bot @shahidhk @rikinsk