这是indexloc提供的服务，不要输入任何密码
Skip to content

Touch-up AuthGuardian guide #3958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Mar 2, 2020
Merged

Touch-up AuthGuardian guide #3958

merged 20 commits into from
Mar 2, 2020

Conversation

@sgrove
Copy link
Contributor

@sgrove sgrove commented Feb 26, 2020

Description

A follow on to #3952 (superseding it since I can't PR to original branch) for AuthGuardian docs

Affected components

  • Docs

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 26, 2020

Beep boop! 🤖

Hey @sgrove, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@claassistantio
Copy link

claassistantio commented Feb 26, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Feb 26, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit b7c9ea0

https://deploy-preview-3958--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 26, 2020

Review app for commit 5bf190b deployed to Heroku: https://hge-ci-pull-3958.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3958-5bf190b8

@marionschleifer marionschleifer added the c/docs Related to docs label Feb 27, 2020
marionschleifer
marionschleifer suggested changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@marionschleifer marionschleifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgrove thank you so much for making these changes. I have some small things, including the different title in the side bar. And changed the doc title to the same too 🙂

sgrove and others added 11 commits February 29, 2020 04:26
@sgrove @marionschleifer
Update docs/graphql/manual/guides/integrations/auth-guardian-jwt.rst
77f7cb2 
Co-Authored-By: Marion Schleifer <marion@hasura.io>
@sgrove @marionschleifer
Update docs/graphql/manual/guides/integrations/auth-guardian-jwt.rst
454a46d 
Co-Authored-By: Marion Schleifer <marion@hasura.io>
@sgrove @marionschleifer
Update docs/graphql/manual/guides/integrations/auth-guardian-jwt.rst
5f091c7 
Co-Authored-By: Marion Schleifer <marion@hasura.io>
@sgrove @marionschleifer
Update docs/graphql/manual/guides/integrations/auth-guardian-jwt.rst
7b7ac68 
Co-Authored-By: Marion Schleifer <marion@hasura.io>
@sgrove @marionschleifer
Update docs/graphql/manual/guides/integrations/auth-guardian-jwt.rst
877d18d 
Co-Authored-By: Marion Schleifer <marion@hasura.io>
@sgrove @marionschleifer
Update docs/graphql/manual/guides/integrations/auth-guardian-jwt.rst
495171c 
Co-Authored-By: Marion Schleifer <marion@hasura.io>
@sgrove @marionschleifer
Update docs/graphql/manual/guides/integrations/auth-guardian-jwt.rst
072fa4a 
Co-Authored-By: Marion Schleifer <marion@hasura.io>
@sgrove @marionschleifer
Update docs/graphql/manual/guides/integrations/auth-guardian-jwt.rst
0dc3e3b 
Co-Authored-By: Marion Schleifer <marion@hasura.io>
@sgrove @marionschleifer
Update docs/graphql/manual/guides/integrations/auth-guardian-jwt.rst
52c2a68 
Co-Authored-By: Marion Schleifer <marion@hasura.io>
@sgrove @marionschleifer
Update docs/graphql/manual/guides/integrations/index.rst
0b74716 
Co-Authored-By: Marion Schleifer <marion@hasura.io>
@sgrove @marionschleifer
Update docs/graphql/manual/guides/integrations/auth-guardian-jwt.rst
702626b 
Co-Authored-By: Marion Schleifer <marion@hasura.io>
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 28, 2020

Review app for commit 702626b deployed to Heroku: https://hge-ci-pull-3958.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3958-702626ba

marionschleifer
marionschleifer previously approved these changes Mar 2, 2020
View reviewed changes
@rikinsk rikinsk merged commit 90f46c0 into hasura:master Mar 2, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 2, 2020

Beep boop! 🤖

GIF

Awesome work @sgrove! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 2, 2020

Review app https://hge-ci-pull-3958.herokuapp.com is deleted

@rikinsk rikinsk mentioned this pull request Mar 2, 2020
Closed
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 2, 2020

Review app for commit b7c9ea0 deployed to Heroku: https://hge-ci-pull-3958.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3958-b7c9ea04

scriptnull pushed a commit that referenced this pull request Mar 17, 2022
@codedmart @scriptnull
Merge pull request #3958 from hasura/abooij/rebase-relay-relationships
88bd863 
Fix remote relationships logic for Relay

GitOrigin-RevId: 5410174d98a12a92d05cd41a5775c65e7fb0e62d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@marionschleifer marionschleifer marionschleifer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/docs Related to docs community-contrib 🙏🏽

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sgrove @hasura-bot @claassistantio @marionschleifer @rikinsk