这是indexloc提供的服务，不要输入任何密码
Skip to content

console changes for actions #3889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Feb 19, 2020
Merged

console changes for actions #3889

merged 21 commits into from
Feb 19, 2020

Conversation

@wawhal
Copy link
Contributor

@wawhal wawhal commented Feb 15, 2020

Description

Console changes for actions

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code

    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields

    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

@wawhal wawhal requested a review from beerose as a code owner February 15, 2020 03:54
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 15, 2020

Review app for commit e4b97d7 deployed to Heroku: https://hge-ci-pull-3889.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3889-e4b97d7f

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 17, 2020

Review app for commit b3c3c80 deployed to Heroku: https://hge-ci-pull-3889.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3889-b3c3c80e

rikinsk
rikinsk previously requested changes Feb 17, 2020
View reviewed changes
@rikinsk rikinsk added the c/console Related to console label Feb 17, 2020
beerose
beerose previously approved these changes Feb 17, 2020
View reviewed changes
@beerose beerose self-requested a review February 17, 2020 09:42
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 17, 2020

Review app for commit 98268a0 deployed to Heroku: https://hge-ci-pull-3889.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3889-98268a0c

beerose
beerose previously approved these changes Feb 17, 2020
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 17, 2020

Review app for commit 9782fc0 deployed to Heroku: https://hge-ci-pull-3889.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3889-9782fc0d

@rikinsk rikinsk self-requested a review February 17, 2020 13:58
beerose
beerose previously approved these changes Feb 17, 2020
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 17, 2020

Review app for commit c2c4dd6 deployed to Heroku: https://hge-ci-pull-3889.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3889-c2c4dd69

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 17, 2020

Review app for commit f00cc21 deployed to Heroku: https://hge-ci-pull-3889.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3889-f00cc21b

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 17, 2020

Review app for commit 14caae4 deployed to Heroku: https://hge-ci-pull-3889.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3889-14caae46

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 18, 2020

Review app for commit 9e77b1b deployed to Heroku: https://hge-ci-pull-3889.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3889-9e77b1be

@rikinsk
Copy link
Member

rikinsk commented Feb 18, 2020

/heroku deploy

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 18, 2020

Review app for commit de39416 deployed to Heroku: https://hge-ci-pull-3889.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3889-de39416d

rikinsk
rikinsk previously approved these changes Feb 18, 2020
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 18, 2020

Review app for commit 062ef0c deployed to Heroku: https://hge-ci-pull-3889.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3889-062ef0c1

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 19, 2020

Review app for commit 67599e8 deployed to Heroku: https://hge-ci-pull-3889.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3889-67599e82

@rikinsk rikinsk merged commit 6b8c7ef into hasura:master Feb 19, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 19, 2020

Review app https://hge-ci-pull-3889.herokuapp.com is deleted

@beerose beerose mentioned this pull request Mar 26, 2020
Merged
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wawhal @hasura-bot @rikinsk @beerose