这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@paf31
Copy link
Contributor

@paf31 paf31 commented Feb 13, 2020

Description

I missed this in my PR for #384. I noticed the existing docs were incorrect, so I fixed a few mistakes too. Namely:

  • There was a reference to check which didn't exist previously, presumably copied from the insert API docs.
  • The set example didn't really make sense since you wouldn't want to set the article ID to a user ID value.

Affected components

  • Docs

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No

Does this PR add a new Metadata feature?

  • No

GraphQL

  • No new GraphQL schema is generated

Breaking changes

  • No Breaking changes

@netlify
Copy link

netlify bot commented Feb 13, 2020

Deploy preview for hasura-docs ready!

Built with commit 2f6a7c6

https://deploy-preview-3883--hasura-docs.netlify.com

Copy link
Contributor

@marionschleifer marionschleifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small changes, otherwise all good 🙂

Co-Authored-By: Marion Schleifer <marion@hasura.io>
@tirumaraiselvan tirumaraiselvan added this to the v1.2.0 milestone Mar 13, 2020
Copy link
Member

@rikinsk rikinsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paf31 Could you also update the definition of UpdatePermissions type described here

@paf31 paf31 closed this Mar 16, 2020
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-3883.herokuapp.com is deleted

@paf31 paf31 deleted the check-docs branch March 16, 2020 19:55
@tirumaraiselvan tirumaraiselvan removed this from the v1.2 milestone Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/docs Related to docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants