这是indexloc提供的服务，不要输入任何密码
Skip to content

show pre-release notifications on console with opt out option #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 18, 2020
Merged

show pre-release notifications on console with opt out option #3888

merged 3 commits into from
Feb 18, 2020

Conversation

@rikinsk
Copy link
Member

@rikinsk rikinsk commented Feb 14, 2020 •
edited
Loading

Description

Show update notifications for pre-release versions with a disclaimer and option to opt out of pre-release notifications

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Solution and Design

If user opts out, persist choice in the DB via console_state field of hdb_version

Steps to test and verify

Limitations, known bugs & workarounds

@rikinsk rikinsk added the c/console Related to console label Feb 14, 2020
@rikinsk rikinsk requested a review from beerose as a code owner February 14, 2020 14:30
@rikinsk rikinsk changed the title show pre-release notifications on console with op out option show pre-release notifications on console with opt out option Feb 14, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 14, 2020

Review app for commit 084c392 deployed to Heroku: https://hge-ci-pull-3888.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3888-084c3929

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 17, 2020

Review app for commit 2e57c5b deployed to Heroku: https://hge-ci-pull-3888.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3888-2e57c5bb

beerose
beerose reviewed Feb 18, 2020
View reviewed changes
console/src/components/Common/utils/localStorageUtils.js
@@ -0,0 +1,12 @@
export const getLocalStorageItem = key => {
Copy link
Contributor

@beerose beerose Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have utility functions for local storage here: https://github.com/hasura/graphql-engine/blob/master/console/src/utils/localstorage.js,
and they are not used anywhere. Maybe we can get rid of them, so there aren't multiple local storage utils files?

Copy link
Member Author

@rikinsk rikinsk Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beerose That is true. This one seems to be a better implemementation of the functions but seems to be unused anywhere in the codebase as of now. Can you approve this for now. I'll raise another PR right after this with a refactor of the localStorage utils usage across the code.

Copy link
Contributor

@beerose beerose Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Cool.

@rikinsk rikinsk merged commit ff3ac78 into hasura:master Feb 18, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 18, 2020

Review app https://hge-ci-pull-3888.herokuapp.com is deleted

@rikinsk rikinsk deleted the console-beta-notif branch February 18, 2020 09:35
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 18, 2020

Review app for commit 681d354 deployed to Heroku: https://hge-ci-pull-3888.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3888-681d354b

rikinsk added a commit to rikinsk/graphql-engine that referenced this pull request Feb 19, 2020
@rikinsk
console: show pre-release update notifications with opt out option (h…
eaaeb7e 
…asura#3888)
shahidhk pushed a commit that referenced this pull request Feb 19, 2020
@rikinsk
v1.1.0-beta.3 console fixes (#3905)
20d9cd1 
* handle invalid keys in permission builder (close #3848) (#3863)

* handle non-existent column names
* handle invalid _exist operator expression keys
* handle non-array values for _and/_or operators

* console: show pre-release update notifications with opt out option (#3888)
karthikvt26 pushed a commit to karthikvt26/graphql-engine that referenced this pull request Nov 17, 2020
@rikinsk @karthikvt26
v1.1.0-beta.3 console fixes (hasura#3905)
3a287fe 
* handle invalid keys in permission builder (close hasura#3848) (hasura#3863)

* handle non-existent column names
* handle invalid _exist operator expression keys
* handle non-array values for _and/_or operators

* console: show pre-release update notifications with opt out option (hasura#3888)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beerose beerose

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rikinsk @hasura-bot @beerose