cli: allow managing actions #3859
Conversation
* extract permissions table into smaller components * v1 actions permissions * set permissions defaults on unmount * change role field to role_name in action perm * handle async state for buttons
…gine-internal into actions-scaffolder-cli
|
Review app for commit 2a99583 deployed to Heroku: https://hge-ci-pull-3859.herokuapp.com |
|
Review app for commit 004d446 deployed to Heroku: https://hge-ci-pull-3859.herokuapp.com |
rikinsk
left a comment
There was a problem hiding this comment.
Tested. Most workflows I could think of seem to work.
|
Review app for commit 597c6d8 deployed to Heroku: https://hge-ci-pull-3859.herokuapp.com |
|
Review app for commit 42dbb67 deployed to Heroku: https://hge-ci-pull-3859.herokuapp.com |
…ql-engine into actions-scaffolder-cli
…ql-engine into actions-scaffolder-cli
…ql-engine into actions-scaffolder-cli
|
Review app for commit 19435b0 deployed to Heroku: https://hge-ci-pull-3859.herokuapp.com |
|
Review app https://hge-ci-pull-3859.herokuapp.com is deleted |
| actionsCodegen | ||
| } = require('./services'); | ||
| const fs = require('fs'); | ||
| const { getFlagValue, OUTPUT_FILE_FLAG } = require('./utils/commandUtils'); |
There was a problem hiding this comment.
Is there any reason for having import "regenerator-runtime/runtime" instead of require("regenerator-runtime/runtime");? If we're using require everywhere else then we should stick to it.
| const rootArg = commandArgs[2]; | ||
| switch(rootArg) { | ||
| case 'sdl': | ||
| const sdlSubCommands = commandArgs.slice(3); |
There was a problem hiding this comment.
Do you need to create a variable for that?
| const sdlSubCommands = commandArgs.slice(3); | ||
| return sdl(sdlSubCommands); | ||
| case 'actions-codegen': | ||
| const actionCodegenSubCommands = commandArgs.slice(3); |
| @@ -0,0 +1,10 @@ | |||
| import "regenerator-runtime/runtime"; | |||
There was a problem hiding this comment.
The same as for cli-ext/src/command.js
| const requestHandler = (payload) => { | ||
|
|
||
| const { | ||
| body, status |
There was a problem hiding this comment.
status is not used anywhere.
| @@ -0,0 +1,114 @@ | |||
| const { buildSchema, printSchema, parse } = require('graphql'); | |||
| const { codegen } = require('@graphql-codegen/core'); | |||
| const typescriptPlugin = require('@graphql-codegen/typescript'); | |||
| return codegenerator; | ||
| } catch (e) { | ||
| throw e; | ||
| } |
There was a problem hiding this comment.
What about removing this try catch?
| return codegenerator; | ||
| } catch (e) { | ||
| throw e; | ||
| } |
| codegenerator = await resolveCodegeneratorFromUrl(codegeneratorPath); | ||
| } | ||
| } catch (e) { | ||
| throw e; |
| try { | ||
| codegenerator = await resolveCodegenerator(codegenConfig) | ||
| } catch (e) { | ||
| throw e; |
There was a problem hiding this comment.
Ditto. It would be handled on line 104.
Description
This PR introduces the v2 workflow for CLI to manage metadata and migrations. It also adds support for creating actions and managing types.
Affected components