fix update event trigger & dropping triggers on run_sql (fix #3803, #3784)
#3833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit 6ae1d91 |
Contributor
|
Review app for commit 6ae1d91 deployed to Heroku: https://hge-ci-pull-3833.herokuapp.com |
6ae1d91 to
8a7f3d8
Compare
Contributor
|
Review app for commit 8a7f3d8 deployed to Heroku: https://hge-ci-pull-3833.herokuapp.com |
8a7f3d8 to
76267a6
Compare
Contributor
|
Review app for commit 76267a6 deployed to Heroku: https://hge-ci-pull-3833.herokuapp.com |
0x777
approved these changes
Feb 5, 2020
Contributor
|
Review app for commit 0a654bb deployed to Heroku: https://hge-ci-pull-3833.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-3833.herokuapp.com is deleted |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
…#3803 hasura#3784 (hasura#3833) Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the following issues:-
#3784 - Event triggers are lost on
run_sqlDDL queries.#3803 - Event trigger is being wiped on recreating
Affected components
Related Issues
#3784 #3803
Solution and Design
3784:- Recreate all event triggers at the end of a
run_sqlDDL query.3803:- Move delete trigger logic to build schema cache. If ops definition changes, the trigger is deleted (if exists) and created again with updated definition.
Steps to test and verify
run_sqlquery with DDL statement shouldn't drop any trigger procedures in thehdb_viewsschemahdb_viewsschema.Limitations, known bugs & workarounds
Server checklist
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
GraphQL
Breaking changes