这是indexloc提供的服务,不要输入任何密码
Skip to content

update checks on ci systems (close #319) #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 12, 2018
Merged

Conversation

shahidhk
Copy link
Member

@shahidhk shahidhk commented Sep 9, 2018

No description provided.

@shahidhk shahidhk added the c/server Related to server label Sep 9, 2018
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-383.herokuapp.com

0x777
0x777 previously approved these changes Sep 11, 2018
@shahidhk shahidhk added the s/do-not-merge Do not merge this pull request to master label Sep 11, 2018
@shahidhk
Copy link
Member Author

Need some more update

@shahidhk shahidhk changed the title disable update checks on ci systems (close #319) update checks on ci systems (close #319) Sep 12, 2018
@shahidhk shahidhk removed the s/do-not-merge Do not merge this pull request to master label Sep 12, 2018
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-383.herokuapp.com

@shahidhk shahidhk merged commit be20a11 into hasura:master Sep 12, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-383.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Mar 21, 2024
I got frustrated by the lack of useful output when services failed to
start in CI, so I thought I'd mess around.

I made some changes so that:

1. we wait for services with health checks to report as healthy,
2. we do not rebuild the engine or custom connector when they start,
3. the health checks work (apart from ndc-postgres, which will come
later), and
4. we use environment variables rather than command-line arguments where
possible.

I have also renamed the "agent" binary to "custom-connector", matching
its crate, because it was driving me a little crazy.

V3_GIT_ORIGIN_REV_ID: 8d672b0b25438b54d47368ce82cd236cfdd4e554
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/server Related to server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants