这是indexloc提供的服务，不要输入任何密码
Skip to content

handle invalid keys in permission builder #3863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 12, 2020
Merged

handle invalid keys in permission builder #3863

merged 4 commits into from
Feb 12, 2020

Conversation

@rikinsk
Copy link
Member

@rikinsk rikinsk commented Feb 11, 2020 •
edited
Loading

Description

Permission builer breaks when:

  • column name is manually edited to a non-existent value
  • _where / _table keys are changed under _exists operator
  • object is passed to _or/_and operators

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

#3848

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@rikinsk rikinsk requested a review from beerose as a code owner February 11, 2020 14:05
@rikinsk rikinsk added c/console Related to console s/wip Status: This issue is a work in progress labels Feb 11, 2020
@rikinsk rikinsk changed the title handle invalid column names in permission builder handle invalid keywords in permission builder Feb 11, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 11, 2020

Review app for commit 8f96d19 deployed to Heroku: https://hge-ci-pull-3863.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3863-8f96d19e

@rikinsk rikinsk removed the s/wip Status: This issue is a work in progress label Feb 11, 2020
@rikinsk rikinsk changed the title handle invalid keywords in permission builder handle invalid keys in permission builder Feb 11, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 11, 2020

Review app for commit 726c4e5 deployed to Heroku: https://hge-ci-pull-3863.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3863-726c4e5e

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 12, 2020

Review app for commit cd1f38a deployed to Heroku: https://hge-ci-pull-3863.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3863-cd1f38a0

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 12, 2020

Review app for commit 77c185f deployed to Heroku: https://hge-ci-pull-3863.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3863-77c185fc

@rikinsk rikinsk merged commit 4b78884 into hasura:master Feb 12, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 12, 2020

Review app https://hge-ci-pull-3863.herokuapp.com is deleted

@rikinsk rikinsk deleted the console-fix-permissions branch February 12, 2020 09:15
rikinsk added a commit to rikinsk/graphql-engine that referenced this pull request Feb 19, 2020
@rikinsk
handle invalid keys in permission builder (close hasura#3848) (hasura…
5aff3e1 
…#3863)

* handle non-existent column names
* handle invalid _exist operator expression keys
* handle non-array values for _and/_or operators
shahidhk pushed a commit that referenced this pull request Feb 19, 2020
@rikinsk
v1.1.0-beta.3 console fixes (#3905)
20d9cd1 
* handle invalid keys in permission builder (close #3848) (#3863)

* handle non-existent column names
* handle invalid _exist operator expression keys
* handle non-array values for _and/_or operators

* console: show pre-release update notifications with opt out option (#3888)
karthikvt26 pushed a commit to karthikvt26/graphql-engine that referenced this pull request Nov 17, 2020
@rikinsk @karthikvt26
v1.1.0-beta.3 console fixes (hasura#3905)
3a287fe 
* handle invalid keys in permission builder (close hasura#3848) (hasura#3863)

* handle non-existent column names
* handle invalid _exist operator expression keys
* handle non-array values for _and/_or operators

* console: show pre-release update notifications with opt out option (hasura#3888)
@Allymahmoud Allymahmoud mentioned this pull request Dec 6, 2023
Open
@ptakpatryk ptakpatryk mentioned this pull request Dec 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rikinsk @hasura-bot @beerose