misc console fixes #3813
Merged
misc console fixes #3813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Review app for commit 528b0c9 deployed to Heroku: https://hge-ci-pull-3813.herokuapp.com |
beerose
reviewed
Jan 31, 2020
| } else { | ||
| notificationMessage = error.message; | ||
| } | ||
| } else if (error && error.message && isString(error.message)) { |
Contributor
There was a problem hiding this comment.
No need to check for error because it is already done in line 35.
| } | ||
| } else { | ||
| checked = false; | ||
| } |
Contributor
There was a problem hiding this comment.
What about doing let checked = false so the else statement can be removed?
let checked = false;
if (permissionsState[query]) {
const permittedFields = permissionsState[query][fieldType] || [];
if (permittedFields === '*') {
checked = true;
} else {
checked = permittedFields.includes(fieldName);
}
}
beerose
approved these changes
Jan 31, 2020
Contributor
|
Review app for commit cff6f0d deployed to Heroku: https://hge-ci-pull-3813.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-3813.herokuapp.com is deleted |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
* handle string errors * handle empty columns / computed fields in permissions (hasura#3789) * allow is_null for all operators (hasura#3777)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Affected components
Related Issues
#3789, #3777, #3808
Solution and Design
Steps to test and verify
Limitations, known bugs & workarounds