这是indexloc提供的服务，不要输入任何密码
Skip to content

console: fixed create if not exists issue (fix #3766) #3816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 3, 2020
Merged

console: fixed create if not exists issue (fix #3766) #3816

merged 3 commits into from
Feb 3, 2020

Conversation

@isala404
Copy link
Contributor

@isala404 isala404 commented Feb 1, 2020

Description

Raw SQL feature on console takes "IF" as the name of the create statement if "IF NOT EXISTS" was included in the query after the create type.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

#3766

Solution and Design

Updated the createSQLRegex to exclude "IF NOT EXISTS" while parseing create SQL

Steps to test and verify

  1. Go to Data > SQL
  2. Attempt to create a table
CREATE TABLE IF NOT EXISTS Persons (
    PersonID int,
    LastName varchar(255),
    FirstName varchar(255),
    Address varchar(255),
    City varchar(255)
);
  1. It won't try to take "IF" as the table name

@isala404 isala404 requested a review from rikinsk as a code owner February 1, 2020 08:44
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 1, 2020

Beep boop! 🤖

Hey @mrsupiri, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@claassistantio
Copy link

claassistantio commented Feb 1, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 1, 2020

Review app for commit 891bdb8 deployed to Heroku: https://hge-ci-pull-3816.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3816-891bdb89

@netlify
Copy link

netlify bot commented Feb 3, 2020

Deploy preview for hasura-docs ready!

Built with commit 7bb4fe9

https://deploy-preview-3816--hasura-docs.netlify.com

@rikinsk rikinsk merged commit 79f1603 into hasura:master Feb 3, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 3, 2020

Beep boop! 🤖

GIF

Awesome work @mrsupiri! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 3, 2020

Review app https://hge-ci-pull-3816.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 3, 2020

Review app for commit 02ab182 deployed to Heroku: https://hge-ci-pull-3816.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3816-02ab1829

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@isala404 @polRk
console: handle create if not exists syntax for track table (close ha…
c94a2e4 
…sura#3766) (hasura#3816)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

Assignees

No one assigned

Labels

c/console Related to console community-contrib 🙏🏽

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@isala404 @hasura-bot @claassistantio @rikinsk @marionschleifer