这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@arvi3411301
Copy link
Member

No description provided.

@arvi3411301 arvi3411301 added the c/console Related to console label Sep 7, 2018
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-374.herokuapp.com

@praveenweb
Copy link
Member

Lets remove test_complete.js. And cache cypress module.

@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-374.herokuapp.com

@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-374.herokuapp.com

Copy link
Member

@praveenweb praveenweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arvi3411301 arvi3411301 added the s/ok-to-merge Status: This pull request can be merged to master label Sep 8, 2018
@shahidhk shahidhk changed the title console: updated dependencies add parallel tests and update dependencies Sep 8, 2018
@shahidhk shahidhk merged commit 79a6849 into hasura:master Sep 8, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-374.herokuapp.com is deleted

@arvi3411301 arvi3411301 deleted the console-deps-update branch September 12, 2018 09:02
hasura-bot pushed a commit that referenced this pull request Mar 20, 2024
Add `serde(deny_unknown_fields)` attribute for `Deprecated` struct. In
v3-metadata-build-service, there's a test to ensure no arbitrary
additional properties exists for any schema definition except
`JWTClaimsMap` struct. It actually caught the missing
`deny_unknown_fields` attribute for `Deprecated` struct. This PR also
includes the same test to catch such misses in the future.

V3_GIT_ORIGIN_REV_ID: 2c0a9d2efcd76946885f2e54a364a388e80c283b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants