cli: update go-binddata, fix realize (close #3588) #3687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Deploy preview for hasura-docs ready! Built with commit bf79fe3 |
Contributor
|
Review app for commit ae51df7 deployed to Heroku: https://hge-ci-pull-3687.herokuapp.com |
Member
|
@scriptonist Can you sign the CLI? Also run |
Contributor
|
Review app for commit b22fba4 deployed to Heroku: https://hge-ci-pull-3687.herokuapp.com |
Contributor
|
Review app for commit bf79fe3 deployed to Heroku: https://hge-ci-pull-3687.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-3687.herokuapp.com is deleted |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
* use a maintained version of go-binddata, fix error in `realize start` * run go mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue mentioned here - #3588 (comment)
As a solution we can change the fork of
go-bindatacurrently in use (https://github.com/hasura/go-binddata) to a more maintained one (https://github.com/kevinburke/go-bindata/)Apart from this we encounter the following problem when trying to run
realize start. This has also been fixed by this PR.Affected components
Related Issues
#3588
Breaking changes