这是indexloc提供的服务，不要输入任何密码
Skip to content

fix cache-control header parsing for JWK (fix #3655) #3676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 13, 2020
Merged

fix cache-control header parsing for JWK (fix #3655) #3676

merged 5 commits into from
Jan 13, 2020

Conversation

@ecthiender
Copy link
Contributor

@ecthiender ecthiender commented Jan 10, 2020 •
edited
Loading

Description

Write a proper parser according to the RFC https://tools.ietf.org/html/rfc7234#section-5.2

TODO: handle extended ASCII set This is not required as per https://tools.ietf.org/html/rfc7230#section-1.2

Affected components

  • Server

Related Issues

#3655

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code

    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields

    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

@ecthiender ecthiender added the c/server Related to server label Jan 10, 2020
@netlify
Copy link

netlify bot commented Jan 10, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 6cd347c

https://deploy-preview-3676--hasura-docs.netlify.com

@ecthiender ecthiender force-pushed the fix-3655-jwk-cache-control-regression branch from 63b50e8 to 059c563 Compare January 13, 2020 08:22
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 13, 2020

Review app for commit 059c563 deployed to Heroku: https://hge-ci-pull-3676.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3676-059c5637

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 13, 2020

Review app for commit 4ea4d1e deployed to Heroku: https://hge-ci-pull-3676.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3676-4ea4d1ec

@ecthiender ecthiender marked this pull request as ready for review January 13, 2020 11:28
@lexi-lambda lexi-lambda force-pushed the fix-3655-jwk-cache-control-regression branch from 1fa8886 to 337ac8c Compare January 13, 2020 20:01
lexi-lambda
lexi-lambda approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@lexi-lambda lexi-lambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great. 🙂

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 13, 2020

Review app for commit 6cd347c deployed to Heroku: https://hge-ci-pull-3676.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3676-6cd347cd

@lexi-lambda lexi-lambda merged commit dca8559 into hasura:master Jan 13, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 13, 2020

Review app https://hge-ci-pull-3676.herokuapp.com is deleted

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@ecthiender @polRk
fix cache-control header parsing for JWK (fix hasura#3655) (hasura#3676)
879b365 
write a proper parser according to the RFC
https://tools.ietf.org/html/rfc7234#section-5.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lexi-lambda lexi-lambda lexi-lambda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/server Related to server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ecthiender @hasura-bot @lexi-lambda