这是indexloc提供的服务，不要输入任何密码
Skip to content

Add bigint to frequently used column (close #3524) #3669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 10, 2020
Merged

Add bigint to frequently used column (close #3524) #3669

merged 3 commits into from
Jan 10, 2020

Conversation

@ashishra0
Copy link
Contributor

@ashishra0 ashishra0 commented Jan 9, 2020

Description

Add a new option bigint for id to choose in frequently used column in the console.

Affected components

  • Console

Related Issues

#3524

Solution and Design

Instead of completely removing integer as one of the options for id, The solution was fixed by adding bigint as another option to choose from the list of frequently used columns.

@ashishra0 ashishra0 requested a review from rikinsk as a code owner January 9, 2020 05:51
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 9, 2020

Beep boop! 🤖

Hey @ashishra0, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@netlify
Copy link

netlify bot commented Jan 9, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 8e537c4

https://deploy-preview-3669--hasura-docs.netlify.com

@ashishra0 ashishra0 requested a review from shahidhk as a code owner January 9, 2020 06:01
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 9, 2020

Review app for commit 24357e3 deployed to Heroku: https://hge-ci-pull-3669.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3669-24357e35

rikinsk
rikinsk requested changes Jan 9, 2020
View reviewed changes
Copy link
Member

@rikinsk rikinsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashishra0 The cli change in cli/commands/migrate_test.go doesn't seem to be relevant to this PR. Can we revert it?

@ashishra0
Copy link
Contributor Author

ashishra0 commented Jan 9, 2020 •
edited
Loading

@rikinsk @shahidhk The build errors out because of semver.NewConstraint("<= v1.0.0-rc.1") in migrate_test.go.

@shahidhk
Copy link
Member

shahidhk commented Jan 10, 2020

@ashishra0 Your branch is not up-to-date with master. Hence the CLI change. Merge master into your branch.

@rikinsk rikinsk merged commit 6a4d643 into hasura:master Jan 10, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 10, 2020

Beep boop! 🤖

GIF

Awesome work @ashishra0! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 10, 2020

Review app https://hge-ci-pull-3669.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 10, 2020

Review app for commit 8e537c4 deployed to Heroku: https://hge-ci-pull-3669.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3669-8e537c46

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@ashishra0 @polRk
add bigint id to frequently used columns (close hasura#3524) (hasura#…
2831a1c 
…3669)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

@shahidhk shahidhk Awaiting requested review from shahidhk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ashishra0 @hasura-bot @shahidhk @rikinsk