这是indexloc提供的服务，不要输入任何密码
Skip to content

cli: add browser flag to console command (close #3333) #3601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 8, 2020
Merged

cli: add browser flag to console command (close #3333) #3601

merged 5 commits into from
Jan 8, 2020

Conversation

@ashishra0
Copy link
Contributor

@ashishra0 ashishra0 commented Dec 30, 2019 •
edited
Loading

Description

Add a browser flag to the hasura console command. This flag allows the user to run the hasura console on their choice of browser rather than the default one.

$ hasura console --browser firefox
INFO console running at: http://localhost:9695/ on firefox

The above command with the browser flag will override the default browser for eg chrome and will open the console only on firefox.

Affected components

  • CLI

Related Issues

#3333

Solution and Design

The fix to the issue was to add a new flag to the console command that when invoked with name of browser will open the console only on the specified browser.

@ashishra0 ashishra0 requested a review from shahidhk as a code owner December 30, 2019 07:11
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 30, 2019

Beep boop! 🤖

Hey @ashishra0, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@netlify
Copy link

netlify bot commented Dec 30, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 9e4278d

https://deploy-preview-3601--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 30, 2019

Review app for commit ac8fe1a deployed to Heroku: https://hge-ci-pull-3601.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3601-ac8fe1a2

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 30, 2019

Review app for commit 30d0999 deployed to Heroku: https://hge-ci-pull-3601.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3601-30d0999f

@tibotiber tibotiber mentioned this pull request Jan 6, 2020
Closed
28 tasks
@tibotiber
Copy link
Contributor

tibotiber commented Jan 6, 2020

Tested here and works as expected 👍.

shahidhk
shahidhk requested changes Jan 7, 2020
View reviewed changes
@shahidhk
Copy link
Member

shahidhk commented Jan 7, 2020

Should give credits to @tibotiber too when merging.

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 7, 2020

Review app for commit 9e4278d deployed to Heroku: https://hge-ci-pull-3601.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3601-9e4278d2

@shahidhk shahidhk added the c/cli Related to CLI label Jan 7, 2020
@shahidhk shahidhk changed the title add browser flag to console command (close #3333) cli: add browser flag to console command (close #3333) Jan 8, 2020
@shahidhk shahidhk merged commit 2fc49ea into hasura:master Jan 8, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 8, 2020

Beep boop! 🤖

GIF

Awesome work @ashishra0! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 8, 2020

Review app https://hge-ci-pull-3601.herokuapp.com is deleted

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@ashishra0 @tibotiber @polRk
cli: add browser flag to console command (close hasura#3333) (hasura#…
510f99a 
…3601)

Co-authored-by: Ashish Rao <ashishrao@hasura.io>
Co-authored-by: Thibaut Tiberghien <thibaut@smplrspace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk approved these changes

Assignees

No one assigned

Labels

c/cli Related to CLI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ashishra0 @hasura-bot @tibotiber @shahidhk