这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@arvi3411301
Copy link
Member

Description

CLI doesn't execute migration in the correct order for --version flag.
This PR fixes the execution order for down migration.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

#3621

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code
    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields
    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

@arvi3411301 arvi3411301 added the c/cli Related to CLI label Jan 3, 2020
@arvi3411301 arvi3411301 requested a review from shahidhk January 3, 2020 07:51
@netlify
Copy link

netlify bot commented Jan 3, 2020

Deploy preview for hasura-docs ready!

Built with commit d359207

https://deploy-preview-3625--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

Review app for commit d359207 deployed to Heroku: https://hge-ci-pull-3625.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3625-d359207e

@shahidhk shahidhk changed the title cli: fix to execute down migration in the correct order for version flag cli: fix to execute down migration in the correct order for version flag (close #3621) Jan 6, 2020
@shahidhk shahidhk changed the title cli: fix to execute down migration in the correct order for version flag (close #3621) cli(fix): execute down migration in the correct order for version flag (close #3621) Jan 6, 2020
@shahidhk shahidhk changed the title cli(fix): execute down migration in the correct order for version flag (close #3621) cli(fix): execute down migration in the correct order Jan 6, 2020
@shahidhk shahidhk merged commit bf98f15 into hasura:master Jan 6, 2020
@shahidhk shahidhk deleted the issue-3621 branch January 6, 2020 09:51
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-3625.herokuapp.com is deleted

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/cli Related to CLI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants