这是indexloc提供的服务，不要输入任何密码
Skip to content

console: add hasura pro popup button #3594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 8, 2020
Merged

console: add hasura pro popup button #3594

merged 13 commits into from
Jan 8, 2020

Conversation

@surendran82
Copy link
Contributor

@surendran82 surendran82 commented Dec 26, 2019 •
edited by karthikvt26
Loading

Description

This PR adds PRO placeholder on the console navbar.

Affected components

  • Console

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code

    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields

    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

@netlify
Copy link

netlify bot commented Dec 26, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 171d393

https://deploy-preview-3594--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 26, 2019

Review app for commit ed8a056 deployed to Heroku: https://hge-ci-pull-3594.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3594-ed8a0562

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 26, 2019

Review app for commit 4a10d94 deployed to Heroku: https://hge-ci-pull-3594.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3594-4a10d94c

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 26, 2019

Review app for commit ae3923f deployed to Heroku: https://hge-ci-pull-3594.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3594-ae3923fa

@rikinsk rikinsk added the c/console Related to console label Dec 26, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 26, 2019

Review app for commit 4c0ede2 deployed to Heroku: https://hge-ci-pull-3594.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3594-4c0ede20

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 26, 2019

Review app for commit 16466e4 deployed to Heroku: https://hge-ci-pull-3594.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3594-16466e45

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 27, 2019

Review app for commit a4cd24b deployed to Heroku: https://hge-ci-pull-3594.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3594-a4cd24be

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 4, 2020

Review app for commit 96c404f deployed to Heroku: https://hge-ci-pull-3594.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3594-96c404fe

@karthikvt26 karthikvt26 requested a review from rikinsk January 6, 2020 07:24
@karthikvt26 karthikvt26 marked this pull request as ready for review January 6, 2020 07:24
@shahidhk shahidhk changed the title Pro placeholder update in header console: add hasura pro popup button Jan 6, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 6, 2020

Review app for commit f1c2865 deployed to Heroku: https://hge-ci-pull-3594.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3594-f1c2865f

@rikinsk rikinsk requested a review from coco98 January 7, 2020 07:09
rikinsk
rikinsk previously approved these changes Jan 8, 2020
View reviewed changes
rikinsk
rikinsk requested changes Jan 8, 2020
View reviewed changes
Copy link
Member

@rikinsk rikinsk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karthikvt26 Hey. Is the change to community/sample-apps/vuetify-vuex-todo-graphql/public/img/icons/safari-pinned-tab.svg intentional? Also doesnt seem like there should be a change to package-lock.json here.

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 8, 2020

Review app for commit 04a7c4d deployed to Heroku: https://hge-ci-pull-3594.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3594-04a7c4de

@karthikvt26
Copy link
Contributor

karthikvt26 commented Jan 8, 2020

@rikinsk we can revert the package-lock.json and I am not sure how this (community/sample-apps/vuetify-vuex-todo-graphql/public/img/icons/safari-pinned-tab.svg) file changed. But it looks like the content is same.

cc: @surendran82

@rikinsk rikinsk merged commit 7e95463 into hasura:master Jan 8, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 8, 2020

Review app https://hge-ci-pull-3594.herokuapp.com is deleted

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@surendran82 @polRk
console: add hasura pro info button (hasura#3594)
ca1081a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

@coco98 coco98 Awaiting requested review from coco98

Assignees

No one assigned

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@surendran82 @hasura-bot @karthikvt26 @rikinsk