fix absence of "args" input field omits session variable argument for v2 functions (fix #3575) #3585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit d8f9e38 |
Contributor
|
/heroku deploy |
Contributor
|
Review app for commit 5ad8898 deployed to Heroku: https://hge-ci-pull-3585.herokuapp.com |
lexi-lambda
approved these changes
Dec 26, 2019
Contributor
|
Review app for commit d8f9e38 deployed to Heroku: https://hge-ci-pull-3585.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-3585.herokuapp.com is deleted |
|
Is there a chance for minor release for this? |
Contributor
|
Can confirm preview app via docker image works. |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For custom SQL functions, the
argsinput field is not generated if the function does not have any input arguments other than the session variable argument. In such a case, the omission ofargsinput field defaults to empty arguments and session variable argument is ignored. This is creating a Postgres query error since the SQL function is executed with no input arguments. Refer to the related issue (see below) for more details.This PR fixes the above-said issue.
Affected components
Related Issues
Fix #3576
Solution and Design
parseFunctionArgsfunction is improved to acceptargsinput field value asMaybetype.argsinput provided, the known argument values (in this case session variable argument) are resolved as positional arguments.Server checklist
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
GraphQL
Breaking changes
Steps to test and verify
Limitations, known bugs & workarounds