这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@nizar-m
Copy link
Contributor

@nizar-m nizar-m commented Dec 17, 2019

Right now on errors, only the expected and the actual responses are
shown. The actual response sometimes may not have all the information,
and you may have to look at the logs. In this case, request id would be
of great help to get the extra information from the logs.

Description

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Solution and Design

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code
    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields
    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

Steps to test and verify

Limitations, known bugs & workarounds

Right now on errors, only the expected and the actual responses are
shown. The actual response sometimes may not have all the information,
and you may have to look at the logs. In this case, request id would be
of great help to get the extra information from the logs.
@nizar-m nizar-m added the c/server Related to server label Dec 17, 2019
@netlify
Copy link

netlify bot commented Dec 17, 2019

Deploy preview for hasura-docs ready!

Built with commit 2a637e1

https://deploy-preview-3556--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

Review app for commit 541dbfc deployed to Heroku: https://hge-ci-pull-3556.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3556-541dbfc1

@hasura-bot
Copy link
Contributor

Review app for commit af53a02 deployed to Heroku: https://hge-ci-pull-3556.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3556-af53a022

@hasura-bot
Copy link
Contributor

Review app for commit c8c0290 deployed to Heroku: https://hge-ci-pull-3556.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3556-c8c02906

@nizar-m nizar-m marked this pull request as ready for review December 24, 2019 08:02
@nizar-m nizar-m requested a review from lexi-lambda as a code owner December 24, 2019 08:02
@hasura-bot
Copy link
Contributor

Review app for commit 4e45edd deployed to Heroku: https://hge-ci-pull-3556.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3556-4e45edd9

@hasura-bot
Copy link
Contributor

Review app for commit 2a637e1 deployed to Heroku: https://hge-ci-pull-3556.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3556-2a637e1f

@lexi-lambda lexi-lambda merged commit 1fca759 into hasura:master Dec 25, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-3556.herokuapp.com is deleted

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
Right now on errors, only the expected and the actual responses are
shown. The actual response sometimes may not have all the information,
and you may have to look at the logs. In this case, request id would be
of great help to get the extra information from the logs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/server Related to server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants