这是indexloc提供的服务，不要输入任何密码
Skip to content

fix feature compatibility version check expression #3546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 17, 2019
Merged

fix feature compatibility version check expression #3546

merged 5 commits into from
Dec 17, 2019

Conversation

@rikinsk
Copy link
Member

@rikinsk rikinsk commented Dec 16, 2019 •
edited
Loading

Description

PR forked from release-v1.0 attempting to fix console test failures in the branch

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Solution and Design

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code

    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields

    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

Steps to test and verify

Limitations, known bugs & workarounds

@rikinsk rikinsk changed the title update manifests to v1.0.0 fix console tests Dec 16, 2019
@netlify
Copy link

netlify bot commented Dec 16, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit b01a0dd

https://deploy-preview-3546--hasura-docs.netlify.com

@rikinsk rikinsk added the s/do-not-merge Do not merge this pull request to master label Dec 16, 2019
@rikinsk
Revert "update wait time"
b01a0dd 
This reverts commit 687501b.
@rikinsk rikinsk changed the base branch from master to release-v1.0 December 16, 2019 11:30
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 16, 2019

Review app for commit 5d93095 deployed to Heroku: https://hge-ci-pull-3546.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3546-5d930952

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 17, 2019

Review app for commit 026b8b8 deployed to Heroku: https://hge-ci-pull-3546.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3546-026b8b8e

@rikinsk rikinsk changed the title fix console tests update feature compatibility version check expression Dec 17, 2019
@shahidhk shahidhk changed the title update feature compatibility version check expression fix feature compatibility version check expression Dec 17, 2019
@shahidhk shahidhk merged commit f0ddbc8 into hasura:release-v1.0 Dec 17, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 17, 2019

Review app https://hge-ci-pull-3546.herokuapp.com is deleted

@rakeshkky rakeshkky removed the s/do-not-merge Do not merge this pull request to master label Dec 18, 2019
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@rikinsk @polRk
fix feature compatibility version check expression (hasura#3546)
1f888bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rikinsk @hasura-bot @shahidhk @rakeshkky