这是indexloc提供的服务，不要输入任何密码
Skip to content

cli: add --dry-run flag to migrate apply (close #3128) #3499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Jun 3, 2020
Merged

cli: add --dry-run flag to migrate apply (close #3128) #3499

merged 32 commits into from
Jun 3, 2020

Conversation

@ashishra0
Copy link
Contributor

@ashishra0 ashishra0 commented Dec 6, 2019 •
edited
Loading

Description

Feature #3128
Flag --dry-run is added to hasura migrate apply command in the CLI. Running the command with this flag will print out the migrations that will be applied.

Usage

$ hasura migrate apply --dry-run
INFO Migrations to be applied:
VERSION        Type  Name
1575986792321  up    create_table_public_testing

@ashishra0 ashishra0 requested a review from shahidhk as a code owner December 6, 2019 11:47
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 6, 2019

Beep boop! 🤖

Hey @ashishra0, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@netlify
Copy link

netlify bot commented Dec 6, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 983bced

https://deploy-preview-3499--hasura-docs.netlify.com

@arvi3411301 arvi3411301 added the c/cli Related to CLI label Dec 6, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 6, 2019

Review app for commit 675b4cd deployed to Heroku: https://hge-ci-pull-3499.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3499-675b4cdb

@shahidhk
Copy link
Member

shahidhk commented Dec 10, 2019

@ashishra0 Can you comment with a screenshot/paste of a sample output?

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 11, 2019

Review app for commit 26f112f deployed to Heroku: https://hge-ci-pull-3499.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3499-26f112f7

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 11, 2019

Review app for commit b51e567 deployed to Heroku: https://hge-ci-pull-3499.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3499-b51e567a

@shahidhk shahidhk requested a review from arvi3411301 December 12, 2019 05:43
@arvi3411301
Copy link
Member

arvi3411301 commented Dec 12, 2019

@ashishra0 @shahidhk can we return an error if both skip-execution and dry-run flag are set to true?

arvi3411301
arvi3411301 requested changes Dec 12, 2019
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 12, 2019

Review app for commit 7cf6219 deployed to Heroku: https://hge-ci-pull-3499.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3499-7cf62190

arvi3411301
arvi3411301 previously approved these changes Dec 12, 2019
View reviewed changes
shahidhk
shahidhk requested changes Dec 12, 2019
View reviewed changes
arvi3411301
arvi3411301 previously approved these changes Dec 12, 2019
View reviewed changes
@scriptonist scriptonist reopened this May 19, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented May 19, 2020

Review app for commit aae9cc6 deployed to Heroku: https://hge-ci-pull-3499.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3499-aae9cc67

@scriptonist scriptonist requested a review from arvi3411301 May 19, 2020 06:34
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 3, 2020

Review app for commit e83bb3c deployed to Heroku: https://hge-ci-pull-3499.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3499-e83bb3ce

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 3, 2020

Review app for commit fdf08bb deployed to Heroku: https://hge-ci-pull-3499.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3499-fdf08bb2

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 3, 2020

Review app for commit e412d7d deployed to Heroku: https://hge-ci-pull-3499.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3499-e412d7d9

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 3, 2020

Review app for commit 5a3a96a deployed to Heroku: https://hge-ci-pull-3499.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3499-5a3a96ab

@scriptonist scriptonist changed the title Add dry run flag (close #3128) cli: add --dry-run flag to migrate apply (close #3128) Jun 3, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 3, 2020

Review app for commit cc40e82 deployed to Heroku: https://hge-ci-pull-3499.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3499-cc40e826

@scriptonist scriptonist requested a review from shahidhk June 3, 2020 10:35
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 3, 2020

Review app for commit 8025085 deployed to Heroku: https://hge-ci-pull-3499.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3499-80250854

tirumaraiselvan
tirumaraiselvan approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog approved

@scriptonist scriptonist merged commit d9cc676 into hasura:master Jun 3, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 3, 2020

Review app https://hge-ci-pull-3499.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 3, 2020

Beep boop! 🤖

GIF

Awesome work @ashishra0! All of us at Hasura ❤️ what you did.

Thanks again 🤗

stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@ashishra0 @stevefan1999-personal
cli: add --dry-run flag to migrate apply command (close hasura#3128) (h…
b68b948 
…asura#3499)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk approved these changes

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

@arvi3411301 arvi3411301 arvi3411301 approved these changes

+1 more reviewer

@scriptonist scriptonist scriptonist approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shraddhaag shraddhaag

Labels

c/cli Related to CLI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ashishra0 @hasura-bot @shahidhk @arvi3411301 @danazkari @scriptonist @tirumaraiselvan @shraddhaag