Fix documentation of HASURA_GRAPHQL_PG_CONNECTIONS #3495
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it clear that
HASURA_GRAPHQL_PG_CONNECTIONSis a hard limit, and document how it relates to stripes.The default here seems okay, but I haven't been able to test on anything other than my laptop so far to test whether I can make this a bottleneck. But it's also not clear to me the value of having a low-ish default... I think a better default would be no limit.
Also it would be nice to log when we're about to block, since this is otherwise going to manifest as a really confusing performance issue for users. A starting point is what I was using to play around:
Affected components