这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@rikinsk
Copy link
Member

@rikinsk rikinsk commented Dec 5, 2019

Description

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Solution and Design

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code
    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields
    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

Steps to test and verify

Limitations, known bugs & workarounds

@rikinsk rikinsk added the c/console Related to console label Dec 5, 2019
@rikinsk rikinsk requested a review from wawhal December 5, 2019 14:20
@netlify
Copy link

netlify bot commented Dec 5, 2019

Deploy preview for hasura-docs ready!

Built with commit ae5745b

https://deploy-preview-3494--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

Review app for commit 1d7382e deployed to Heroku: https://hge-ci-pull-3494.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3494-1d7382e1

Copy link
Contributor

@wawhal wawhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Have added two comments (questions). If they are resolved, I can approve.

wawhal
wawhal previously approved these changes Dec 16, 2019
@hasura-bot
Copy link
Contributor

Review app for commit ae5745b deployed to Heroku: https://hge-ci-pull-3494.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3494-ae5745b7

@rikinsk rikinsk merged commit ee9482f into hasura:master Dec 17, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-3494.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants