Update server/CONTRIBUTING.md and include manual build/test steps #3472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit abc903f |
jberryman
reviewed
Dec 4, 2019
| *.dyn_o | ||
| *.dyn_hi | ||
| .virtualenv | ||
| .python-venv |
Collaborator
There was a problem hiding this comment.
It doesn't seem super important but I was wondering if we should standardize on a single name for python venvs (.python-venv seems good)
Contributor
Author
There was a problem hiding this comment.
I don’t have a strong opinion about the particular name, so anything works for me, really. I just put the name I was using in the .gitignore file. We could use .virtualenv instead, or something else, so let me know if you’d prefer something different!
jberryman
approved these changes
Dec 4, 2019
Collaborator
jberryman
left a comment
There was a problem hiding this comment.
Manual instructions should be super helpful!
Contributor
|
Review app https://hge-ci-pull-3472.herokuapp.com is deleted |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes some problems with
CONTRIBUTING.mdfor the server code, and it adds detailed manual build steps to document how to run the tests without usingscripts/dev.sh, should anyone find that helpful.Affected components