do not update all rows of a table on upsert when action is update (fix #342) #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0x777 In this case if I provide multiple objects with a different schema then there's a query error per Rakesh. Is that ok for now? |
|
Review app available at: https://hge-ci-pull-344.herokuapp.com |
|
Review app available at: https://hge-ci-pull-344.herokuapp.com |
|
Review app available at: https://hge-ci-pull-344.herokuapp.com |
0x777
reviewed
Sep 4, 2018
| (Just cols, _) -> RI.CCUpdate constraint cols | ||
| (Nothing, Just CAIgnore) -> RI.CCDoNothing $ Just constraint | ||
| (Nothing, Just CAUpdate) -> RI.CCUpdate constraint inpCols | ||
| (Nothing, Nothing) -> RI.CCDoNothing $ Just constraint |
There was a problem hiding this comment.
this should also be same as the previous case, when update_columns is missing, we take it that they want to update the specified columns
|
Review app available at: https://hge-ci-pull-344.herokuapp.com |
0x777
approved these changes
Sep 4, 2018
|
Review app https://hge-ci-pull-344.herokuapp.com is deleted |
shahidhk
pushed a commit
to shahidhk/graphql-engine
that referenced
this pull request
Sep 11, 2018
update cli reference doc, microservices doc, close hasura#344
hasura-bot
pushed a commit
that referenced
this pull request
Feb 12, 2021
* Stop shutdown handler retaining the whole serveCtx This might look like quite a strange way to write the function but it's the only way I could get GHC to not capture `serveCtx` in the shutdown handler. Fixes the metadata issue in #344 * Force argumentNames The arguments list is often empty so we end up with a lot of duplicate thunks if this value is not forced. * Increase sharing in nullableType and nonNullableType The previous definitions would lead to increased allocation as it would destory any previously created sharing. The new definition only allocate a fresh constructor if the value is changed. * Add memoization for field parsers It was observed in #344 that many parsers were not being memoised which led to an increase in memory usage. This patch generalisation memoisation so that it works for FieldParsers as well as normal Parsers. There can still be substantial improvement made by also memoising InputFieldParsers but that is left for future work. Co-authored-by: Antoine Leblanc <antoine@hasura.io> * [automated] stylish-haskell commit * changelog Co-authored-by: Phil Freeman <paf31@cantab.net> Co-authored-by: Antoine Leblanc <antoine@hasura.io> Co-authored-by: Stylish Haskell Bot <stylish-haskell@users.noreply.github.com> Co-authored-by: Phil Freeman <phil@hasura.io> GitOrigin-RevId: 36255f7
hasura-bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
V3_GIT_ORIGIN_REV_ID: 279110b4bb1605baa36a2770e5ec0d1530944ed5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.