这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@ecthiender
Copy link
Contributor

Description

Few functions would create their own logger. This is not desirable, as the logger is created during initialization. Creating the logger each time those functions are called can be avoided by simply passing the logger to those functions.

Affected components

  • Server

Related Issues

N/A

Solution and Design

Instead of passing LoggerCtx, pass the Logger directly to those functions.

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No

Metadata

Does this PR add a new Metadata feature?

  • No

GraphQL

  • No new GraphQL schema is generated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code
    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields
    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

Steps to test and verify

Limitations, known bugs & workarounds

@ecthiender ecthiender added the c/server Related to server label Nov 28, 2019
@ecthiender ecthiender requested a review from rakeshkky November 28, 2019 07:26
@netlify
Copy link

netlify bot commented Nov 28, 2019

Deploy preview for hasura-docs ready!

Built with commit 8c7faf6

https://deploy-preview-3439--hasura-docs.netlify.com

Copy link
Member

@rakeshkky rakeshkky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasura-bot
Copy link
Contributor

Review app for commit 8c7faf6 deployed to Heroku: https://hge-ci-pull-3439.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3439-8c7faf62

@shahidhk shahidhk merged commit c9b9ed5 into hasura:master Nov 28, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-3439.herokuapp.com is deleted

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/server Related to server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants