这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@gward
Copy link

@gward gward commented Dec 2, 2019

Description

Doc fix only. Trying to tie together a lot of incomplete, inconsistent information from around the web.

Affected components

  • Docs

Breaking changes

  • No Breaking changes

Limitations, known bugs & workarounds

Did not test for PG 10.

(At least for PostgreSQL 11: I have not tested with PG 10.)
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @gward, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@netlify
Copy link

netlify bot commented Dec 2, 2019

Deploy preview for hasura-docs ready!

Built with commit 27385d7

https://deploy-preview-3460--hasura-docs.netlify.com

@gward
Copy link
Author

gward commented Dec 2, 2019

Oh, #1677 is relevant. Not sure this PR fixes that issue, but it makes things a bit better!

@ecthiender
Copy link
Contributor

@gward did you not have to grant explicit selects for tables in information_schema ? If we have that info as well, then the PR looks complete to me.

@marionschleifer marionschleifer added c/docs Related to docs c/community Related to community content labels Dec 3, 2019
Copy link
Contributor

@ecthiender ecthiender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you not have to grant explicit selects for tables in information_schema ?

@gward
Copy link
Author

gward commented Dec 3, 2019

Did you not have to grant explicit selects for tables in information_schema ?

With PostgreSQL 11: no. The instructions already in the Hasura docs worked for information_schema.

With PostgreSQL 10: it looks like that would be necessary. I did not fully test with PG 10, though, so I am not confident documenting the procedure for PG 10.

@marionschleifer
Copy link
Contributor

@gward thank you for your remarks. Would you mind testing this also with Postgres 10 and adding it to the documentation? 🙂

@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@tirumaraiselvan
Copy link
Contributor

Appreciate your contribution and sorry for the delay in getting this through. But this has been superseded by #5228

@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @gward!

Sorry that your PR wasn’t merged.

Do take a look at any of the other open issues to see if you’d like to take something up! We’re around on Discord if you have any questions 😄

@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-3460.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants