bulk query should not care about access mode of select or count queries #3467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit e0cbe33 |
Contributor
|
Review app for commit d5eb012 deployed to Heroku: https://hge-ci-pull-3467.herokuapp.com |
tirumaraiselvan
commented
Dec 3, 2019
lexi-lambda
suggested changes
Dec 3, 2019
tirumaraiselvan
commented
Dec 4, 2019
| onLeft (reconcileAccessModes expectedMode queryMode) $ \errMode -> | ||
| throw400 BadRequest $ | ||
| "incompatible access mode requirements in bulk query, " <> | ||
| "expected access mode: " <> |
Contributor
Author
There was a problem hiding this comment.
hindent auto formatting
17ba975 to
107c766
Compare
Contributor
|
Review app for commit 107c766 deployed to Heroku: https://hge-ci-pull-3467.herokuapp.com |
lexi-lambda
approved these changes
Dec 4, 2019
Contributor
|
Review app for commit e0cbe33 deployed to Heroku: https://hge-ci-pull-3467.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-3467.herokuapp.com is deleted |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the TODO in #3191 and fixes the commented code in #3465
As RQSelect and RQCount statements could be combined with run_sql queries which mutate data, we had set the tx access mode for them to be READ WRITE to support backwards compatibility in the console.
But the console is doing lots of RQSelect alongside READ ONLY run_sql, which forces the console to continue using run_sql in READ WRITE. This would negate the performance benefit of READ ONLY run_sql in the first place.
This PR fixes that by making RQSelect and RQCount work with both types of access modes.
Affected components