这是indexloc提供的服务，不要输入任何密码
Skip to content

console read only mode #3466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 30, 2019
Merged

console read only mode #3466

merged 10 commits into from
Dec 30, 2019

Conversation

@rikinsk
Copy link
Member

@rikinsk rikinsk commented Dec 3, 2019

Description

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Solution and Design

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code

    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields

    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

Steps to test and verify

Limitations, known bugs & workarounds

@rikinsk rikinsk added s/do-not-merge Do not merge this pull request to master c/console Related to console s/wip Status: This issue is a work in progress labels Dec 3, 2019
@netlify
Copy link

netlify bot commented Dec 3, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 9812306

https://deploy-preview-3466--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 3, 2019

Review app for commit 34c7d3d deployed to Heroku: https://hge-ci-pull-3466.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3466-34c7d3d3

@tirumaraiselvan tirumaraiselvan mentioned this pull request Dec 3, 2019
Merged
1 task
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 5, 2019

Review app for commit 2d97167 deployed to Heroku: https://hge-ci-pull-3466.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3466-2d97167f

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 5, 2019

Review app for commit 58ea11a deployed to Heroku: https://hge-ci-pull-3466.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3466-58ea11a1

@rikinsk rikinsk removed s/do-not-merge Do not merge this pull request to master s/wip Status: This issue is a work in progress labels Dec 6, 2019
@rikinsk rikinsk requested a review from wawhal December 9, 2019 08:44
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 15, 2019

Review app for commit a371141 deployed to Heroku: https://hge-ci-pull-3466.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3466-a371141d

wawhal
wawhal previously approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@wawhal wawhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@rikinsk rikinsk merged commit 69179ad into hasura:master Dec 30, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 30, 2019

Review app https://hge-ci-pull-3466.herokuapp.com is deleted

@rikinsk rikinsk deleted the console-read-only-mode branch December 30, 2019 11:52
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 30, 2019

Review app for commit 9812306 deployed to Heroku: https://hge-ci-pull-3466.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3466-98123064

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@rikinsk @polRk
add base code for console read only mode (hasura#3466)
9062ff5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wawhal wawhal wawhal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wawhal wawhal

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rikinsk @hasura-bot @wawhal