-
Notifications
You must be signed in to change notification settings - Fork 2.8k
allow mutations on views only if they are allowed by postgres (fix #232) #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review app available at: https://hge-ci-pull-339.herokuapp.com |
Resolve Conflicts: server/src-lib/Hasura/GraphQL/Schema.hs
|
Review app available at: https://hge-ci-pull-339.herokuapp.com |
|
upserts should not be allowed on views. |
Resolve Conflicts: server/src-lib/Hasura/GraphQL/Schema.hs
|
Review app available at: https://hge-ci-pull-339.herokuapp.com |
|
Review app available at: https://hge-ci-pull-339.herokuapp.com |
|
@rakeshkky What is blocking this PR? |
|
@shahidhk This PR requires few console changes. Console has to allow creating |
Resolve Conflicts: server/src-lib/Hasura/GraphQL/Schema.hs server/src-lib/Hasura/RQL/Types/SchemaCache.hs
|
Review app available at: https://hge-ci-pull-339.herokuapp.com |
… (hasura#340) * filestore-docs: added PUT api docs and improved fs docs. Fix hasura#339 * filestore-docs: fixed wrong ref
|
@rakeshkky Please resolve server conflicts here too. |
Resolve Conflicts: server/src-lib/Hasura/GraphQL/Schema.hs
|
Review app available at: https://hge-ci-pull-339.herokuapp.com |
|
Review app available at: https://hge-ci-pull-339.herokuapp.com |
|
Review app available at: https://hge-ci-pull-339.herokuapp.com |
|
Test steps:
Test can be performed across the schemas. @rakeshkky Please update in case I have missed any use case. |
|
Review app available at: https://hge-ci-pull-339.herokuapp.com |
|
@karthikvt26 Let's add a note in the permissions UI to indicate why configuration for insert/update/delete is not available as shown below. Also, if it's not too much of a change, show the columns for insert/update/delete like you would for a regular table but disable the options in them. |
|
Review app available at: https://hge-ci-pull-339.herokuapp.com |
|
@karthikvt26 @dsandip - can we enable Insert tab (next to Browse rows) for views that allows mutations? |
|
Review app https://hge-ci-pull-339.herokuapp.com is deleted |
Similar behaviour observed while creating permissions on views.